Page MenuHomePhabricator

Score audio players processed by videoJS are invisible
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable both score and videojs on a single page
  • Example: this

What happens?:

  • After loading videojs, the audio element doesn't have a width rendering it invisible

What should have happened instead?:

  • It should have retained a default width, just as native audio elements do

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Related Objects

Event Timeline

Change 785915 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Provide a fallback width for <audio> players

https://gerrit.wikimedia.org/r/785915

TheDJ moved this task from Backlog to Active on the VideoJS player board.

Change 785915 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Provide a fallback width for <audio> players

https://gerrit.wikimedia.org/r/785915

It looks good but now it looks like this:

image.png (232×646 px, 17 KB)

We need to probably find a way to make it be display: block instead of inline-block for this specific usecase

That's because of <figure> mode I'm pretty sure.

It looks good but now it looks like this:

image.png (232×646 px, 17 KB)

We need to probably find a way to make it be display: block instead of inline-block for this specific usecase

Since it’s functional now, I don’t think much effort should be put into making it look nicer, since chances are that TMH won’t even touch this player at all once T295514 is fixed (and the native player properly appears below the score).