| Pginer-WMF | |
| Aug 25 2017, 9:10 AM |
| F12214942: Screen Shot 2018-01-02 at 4.11.57 PM.png | |
| Jan 3 2018, 12:30 AM |
| F12214943: Screen Shot 2018-01-02 at 4.11.57 PM.png | |
| Jan 3 2018, 12:30 AM |
| F11958052: Screen Shot 2017-12-18 at 4.09.17 PM.png | |
| Dec 20 2017, 8:51 PM |
| F11887748: grafik.png | |
| Dec 17 2017, 12:45 PM |
| F11879500: grafik.png | |
| Dec 17 2017, 3:18 AM |
| F9171554: Screen Shot 2017-08-25 at 11.04.33.png | |
| Aug 25 2017, 9:10 AM |
| F9171559: Screen Shot 2017-08-25 at 11.04.28.png | |
| Aug 25 2017, 9:10 AM |
ContentTranslation editor has a header with options above the translation content, currently there seems to be an unnecessary gap that pushes content down and makes the tool area look disconnected:
The cause seems to be a <fieldset> element:
Either the empty fieldset should not have any height (display: none; for example) ot not be there at all when there is message.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix gap between header and content | mediawiki/extensions/ContentTranslation | master | +3 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T76456 Language Engineering tracker of trackers (tracking) | |||
| Open | None | T127695 Design polishing for Content Translation | |||
| Resolved | divadsn | T174139 Translation editor shows a gap between header and content |
This seems quite simple task which I can mentor. Either the empty fieldset should not have any height (display: none; for example) ot not be there at all when there is message.
Sorry, but sadly I can't reproduce the bug on the Wikipedia ContentTranslation page and my local vagrant had problems running the contenttranslation role.
Please check my screenshot below.
If it comes to the gap between, the cause isn't the fieldset anymore, it's a wrong CSS rule here:
Change 398691 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/extensions/ContentTranslation@master] Fix gap between header and content
Change 398691 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix gap between header and content
I will need to check it in production to make sure that the additional messages can be displayed there.
wmf.12
Checked per my previous comment - in testwiki (wmf.15) I saw that the additional message does not quite fit anymore:
@divadsn - can your fix accommodate the case when there is some additional messages need to be displayed?
I filed the issue from my previous comment as T184130: [wmf.15-regression] ContentTranslation page: the additional message not displayed correctly and closing this ticket as Resolved.