Page MenuHomePhabricator
Create Task
Maniphest T184130

[wmf.15-regression] ContentTranslation page: the additional message not displayed correctly
Closed, ResolvedPublic
Actions

Assigned To
• Petar.petkovic
Authored By
Etonkovidova
Jan 3 2018, 10:56 PM
Tags
Referenced Files
F12516875: Screen Shot 2018-01-12 at 12.26.10 PM.png
Jan 12 2018, 8:37 PM
F12347460: Screen Shot 2018-01-09 at 1.38.11 PM.png
Jan 9 2018, 9:57 PM
F12214943: Screen Shot 2018-01-02 at 4.11.57 PM.png
Jan 3 2018, 10:56 PM
F12214942: Screen Shot 2018-01-02 at 4.11.57 PM.png
Jan 3 2018, 10:56 PM
Subscribers
Aklapper
Etonkovidova
gerritbot
KartikMistry
• mmodell
Nikerabbit
• Petar.petkovic
View All 10 Subscribers

Description

In wmf.15 I saw that the additional message displayed on ContentTranslation page does not quite fit anymore:
(the screenshots are from testwiki)

Screen Shot 2018-01-02 at 4.11.57 PM.png (551×1 px, 220 KB)

In wmf.16 the message cannot be dismissed:

Screen Shot 2018-01-09 at 1.38.11 PM.png (355×1 px, 93 KB)

Details

SubjectRepoBranchLines +/-
CX1: Fix translation view UI overlapsmediawiki/extensions/ContentTranslationwmf/1.31.0-wmf.16+16 -6
CX1: Fix translation view UI overlapsmediawiki/extensions/ContentTranslationmaster+16 -6
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jan 3 2018, 10:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2018, 10:56 PM
Etonkovidova mentioned this in T174139: Translation editor shows a gap between header and content.Jan 3 2018, 10:57 PM
• Petar.petkovic added subscribers: Nikerabbit, Pginer-WMF, • santhosh.Jan 3 2018, 10:58 PM
Etonkovidova renamed this task from [wmf.15] ContentTranslation page: the additional message not displayed correctly to [wmf.15-regression] ContentTranslation page: the additional message not displayed correctly .Jan 4 2018, 12:12 AM
• mmodell subscribed.Jan 4 2018, 7:16 PM

Should this be a blocker for T180748: 1.31.0-wmf.15 deployment blockers? I guess probably not?

KartikMistry added a comment.Jan 5 2018, 4:55 AM

@mmodell Not blocker. Thanks for heads up!

Etonkovidova updated the task description. (Show Details)Jan 9 2018, 9:57 PM
• Petar.petkovic moved this task from Needs Triage to April-June 2018 on the ContentTranslation board.Jan 11 2018, 3:01 PM
• Petar.petkovic added a project: Language-2018-Jan-Mar.
gerritbot subscribed.Jan 12 2018, 1:02 PM

Change 403918 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] CX1: Fix translation view UI overlaps

https://gerrit.wikimedia.org/r/403918

gerritbot added a project: Patch-For-Review.Jan 12 2018, 1:02 PM
• Petar.petkovic claimed this task.Jan 12 2018, 1:02 PM
• Petar.petkovic added a project: Regression.
• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-Jan-Mar board.
gerritbot added a comment.Jan 12 2018, 2:23 PM

Change 403918 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX1: Fix translation view UI overlaps

https://gerrit.wikimedia.org/r/403918

• Petar.petkovic removed a project: Patch-For-Review.Jan 12 2018, 6:32 PM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-Jan-Mar board.
Etonkovidova updated the task description. (Show Details)Jan 12 2018, 8:23 PM
Etonkovidova added a comment.Jan 12 2018, 8:37 PM

Checked in cx-testing (and will check after deployment):

Screen Shot 2018-01-12 at 12.26.10 PM.png (312×1 px, 64 KB)

Etonkovidova closed this task as Resolved.Jan 12 2018, 8:38 PM
gerritbot added a comment.Jan 13 2018, 8:21 AM

Change 404070 had a related patch set uploaded (by KartikMistry; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@wmf/1.31.0-wmf.16] CX1: Fix translation view UI overlaps

https://gerrit.wikimedia.org/r/404070

gerritbot added a project: Patch-For-Review.Jan 13 2018, 8:21 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 13 2018, 8:01 PM
Nikerabbit removed a project: Patch-For-Review.Jan 15 2018, 7:56 AM
Nikerabbit moved this task from QA to Done on the Language-2018-Jan-Mar board.
gerritbot added a comment.Jan 15 2018, 2:17 PM

Change 404070 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@wmf/1.31.0-wmf.16] CX1: Fix translation view UI overlaps

https://gerrit.wikimedia.org/r/404070

Stashbot mentioned this in T184662: [wmf.16 - regression] Cannot click Personal draft button.Jan 15 2018, 2:40 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-01-15T14:40:42Z] <zfilipin@tin> Synchronized php-1.31.0-wmf.16/extensions/ContentTranslation: SWAT: [[gerrit:404070|CX1: Fix translation view UI overlaps (T184662 T184130)]] (duration: 01m 16s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)); removed MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 15 2018, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL