Page MenuHomePhabricator

test_load_from_pageids_comma_separated is failing on Travis
Closed, ResolvedPublic

Description

_______ TestLoadPagesFromPageids.test_load_from_pageids_comma_separated ________
self = <tests.site_tests.TestLoadPagesFromPageids testMethod=test_load_from_pageids_comma_separated>
    def test_load_from_pageids_comma_separated(self):
        """Test loading from comma-separated pageids."""
        pageids = ', '.join(str(page._pageid) for page in self.links)
        gen = self.site.load_pages_from_pageids(pageids)
>       for count, page in enumerate(gen, start=1):
tests/site_tests.py:2527: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pywikibot/site.py:3142: in load_pages_from_pageids
    for sublist in itergroup(filter_unique(gen), groupsize):
pywikibot/tools/__init__.py:637: in itergroup
    for item in iterable:
pywikibot/tools/__init__.py:876: in filter_unique
    for item in iterable:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.0 = <list_iterator object at 0x7fdca5043750>
>   gen = (str(int(p)) for p in pageids if int(p) > 0)
E   ValueError: invalid literal for int() with base 10: ''
pywikibot/site.py:3133: ValueError

see: https://travis-ci.org/wikimedia/pywikibot-core/jobs/177955831#L2109-L2134

Event Timeline

Change 322963 had a related patch set uploaded (by Magul):
Fix of load_from_pageids' test case.

https://gerrit.wikimedia.org/r/322963

Provided above patch is also fixing:

  • test_load_from_pageids_iterable_of_int (see: 1)
  • test_load_from_pageids_iterable_of_str (see: 2)
  • test_load_from_pageids_iterable_with_duplicate (see: 3)

Change 322963 merged by jenkins-bot:
Fix load_pages_from_pageids' test case

https://gerrit.wikimedia.org/r/322963