Page MenuHomePhabricator

[[MediaWiki:Savedrights]] i18n issue
Closed, ResolvedPublic



This message refers to userrights being saved. Actually user groups are being saved. So the message should say for consistency "The user groups of {{GENDER:$1|$1}} have been saved." Messages like "userrights-lookup-user", "userrights-changeable-col" and "userrights-editusergroup" on the very same special page already refer to user groups.

I am aware that this message dates back to the dark ages of MediaWiki so the name of the special page and the name of the log should probably not be touched.

Event Timeline

Kghbln created this task.Nov 23 2016, 2:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2016, 2:44 PM
MarcoAurelio renamed this task from [[MediaWiki:Savedrights/de]] i18n issue to [[MediaWiki:Savedrights]] i18n issue.Nov 23 2016, 5:52 PM
MarcoAurelio claimed this task.
MarcoAurelio triaged this task as Medium priority.

Change 323187 had a related patch set uploaded (by MarcoAurelio):
Change 'rights' to 'groups' on MediaWiki:Savedrights

Changed 'rights' to 'groups' in the above patch both in 'en' and 'qqq'. Let me know if there's something else missing, such as API+* messages needing change as well.

Change 323187 merged by jenkins-bot:
Change 'rights' to 'groups' on MediaWiki:Savedrights

Nikerabbit closed this task as Resolved.Nov 25 2016, 9:10 AM

@MarcoAurelio Thanks for agreeing and fixing. As for the API I am afraid that I cannot tell if it is affected too.

@Kghbln Thanks should be to @Nikerabbit who approved the patch. I'll have a look at the API messages when I've got some time and see if there's anything to change. Regards.

@MarcoAurelio Well you did the typing. :) @Nikerabbit has a subscription on thankyous from me even if not explicitly mentioned. :)