Maniphest T151825

Strict Standards warning
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Rudloff
	Nov 28 2016, 10:02 PM

Tags

Referenced Files

None

Subscribers

Description

I get this warning with CleanChanges 1.28+8a0087c:

Strict Standards: Declaration of NCL::recentChangesLine() should be compatible with EnhancedChangesList::recentChangesLine(&$rc, $watched = false, $linenumber = NULL) in /home/pierre/www/archi-mediawiki/extensions/CleanChanges/CleanChanges_body.php on line 6

Details

	Subject	Repo	Branch	Lines +/-
	Make NCL::recentChangesLine() compatible with EnhancedChangesList::recentChangesLine()	mediawiki/extensions/CleanChanges	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rECLC8a0087cf79e4: Update version before MLEB release

Event Timeline

Rudloff created this task.Nov 28 2016, 10:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2016, 10:02 PM

Any news on this? I can submit a patch if needed.

@Rudloff Please go ahead.

Here is my patch: https://gerrit.wikimedia.org/r/#/c/335029/

Change 335029 had a related patch set uploaded (by Rudloff):
Make NCL::recentChangesLine() compatible with EnhancedChangesList::recentChangesLine()

https://gerrit.wikimedia.org/r/335029

gerritbot added a project: Patch-For-Review.Jan 30 2017, 3:31 PM

Change 335029 merged by jenkins-bot:
Make NCL::recentChangesLine() compatible with EnhancedChangesList::recentChangesLine()

https://gerrit.wikimedia.org/r/335029

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 30 2017, 4:00 PM

Nikerabbit closed this task as Resolved.Jan 30 2017, 4:07 PM

Nikerabbit assigned this task to Rudloff.

Nikerabbit triaged this task as Low priority.

Thanks @Rudloff