Only variables should be assigned by reference in backend/ConfirmAccount.class.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Seb35
	Nov 30 2016, 5:48 PM

Description

I got this PHP notice with ConfirmAccount 0d79eb3 + MW 1.29alpha + PHP 7.0:

Only variables should be assigned by reference in backend/ConfirmAccount.class.php on line 217

The faulty syntax is:

$magic =& MimeMagic::singleton();

When searching in MediaWiki codebase elsewhere for MimeMagic, the usual usage is $magic = MimeMagic::singleton();.

	Subject	Repo	Branch	Lines +/-
	Fix PHP notice 'Only variables should be assigned by reference'	mediawiki/extensions/ConfirmAccount	master	+1 -1

Mentioned Here: rECAC0d79eb3f5957: Localisation updates from https://translatewiki.net.

Change 324515 had a related patch set uploaded (by Seb35):
Fix PHP notice 'Only variables should be assigned by reference'

Seb35 triaged this task as Lowest priority.Nov 30 2016, 6:16 PM

Change 324515 merged by jenkins-bot:
Fix PHP notice 'Only variables should be assigned by reference'

Seb35 closed this task as Resolved.Nov 30 2016, 9:41 PM

Seb35 claimed this task.