[Crash] Unmarshalling error when restoring tabs.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dbrant
	Dec 6 2016, 2:06 PM

Description

Not strictly a crash (logRemoteErrorIfProd), but we seem to have an error in unmarshalling our tabs, where we serialize the namespace of the page as the enum string ("MAIN") instead of the number code.

https://rink.hockeyapp.net/manage/apps/226650/app_versions/64/crash_reasons/148057613

Caused by: java.lang.NumberFormatException: Invalid double: "MAIN"
at java.lang.StringToReal.invalidReal(StringToReal.java:63)
at java.lang.StringToReal.parseName(StringToReal.java:249)
at java.lang.StringToReal.parseDouble(StringToReal.java:273)
at java.lang.Double.parseDouble(Double.java:301)
at com.google.gson.stream.JsonReader.nextInt(JsonReader.java:1193)
at org.wikipedia.json.NamespaceTypeAdapter.read(NamespaceTypeAdapter.java:20)
at org.wikipedia.json.NamespaceTypeAdapter.read(NamespaceTypeAdapter.java:11)
at com.google.gson.TypeAdapter$1.read(TypeAdapter.java:199)
...
at com.google.gson.Gson.fromJson(Gson.java:801)
at org.wikipedia.json.GsonUnmarshaller.unmarshal(GsonUnmarshaller.java:32)
at org.wikipedia.json.GsonUnmarshaller.unmarshal(GsonUnmarshaller.java:19)
at org.wikipedia.json.TabUnmarshaller.unmarshal(TabUnmarshaller.java:21)

Details

	Subject	Repo	Branch	Lines +/-
	Fix deserializing of older Namespace values (and possible crash).	apps/android/wikipedia	master	+19 -2

Customize query in gerrit

Related Objects

Mentioned Here: T152980: [Crash] IllegalArgumentException due to illegal URL: null://null/api/rest_v1/

Event Timeline

Dbrant created this task.Dec 6 2016, 2:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2016, 2:06 PM

Change 325571 had a related patch set uploaded (by Dbrant):
Fix deserializing of older Namespace values (and possible crash).

https://gerrit.wikimedia.org/r/325571

gerritbot added a project: Patch-For-Review.Dec 6 2016, 4:12 PM

Dbrant moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Dec 6 2016, 4:13 PM

Change 325571 merged by jenkins-bot:
Fix deserializing of older Namespace values (and possible crash).

https://gerrit.wikimedia.org/r/325571

Dbrant moved this task from Code Review to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Dec 6 2016, 7:23 PM

Dbrant closed this task as Resolved.Dec 9 2016, 6:26 PM

Dbrant claimed this task.

So...it doesn't look like this is resolved. Looking in HockeyApp, the rate of this crash has not changed since our last release, which indicates that it's not an upgrade-related bug.
Even though it doesn't actually produce a crash, the user sees a very undesirable symptom of having their list of tabs cleared.

Dbrant removed Dbrant as the assignee of this task.Jan 3 2017, 4:13 PM

Dbrant moved this task from Done to To Do on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.

• Niedzielski claimed this task.Jan 27 2017, 4:59 PM

• Niedzielski moved this task from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.

@Dbrant, I don't think this issue specifically is actually happening any longer in the crash report logs of the latest beta. NamespaceTypeAdapterTest.testReadOldData() explicitly exercises this scenario which now succeeds. The unmarshalling errors we're seeing in the latest beta look more like T152980 which I can stimulate in a test but I'm unsure of what the actual JSON looks like (is there an authority somewhere in the JSON we can use?).

I'm gonna mark this guy closed and reopen T152980

[Crash] Unmarshalling error when restoring tabs.Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[Crash] Unmarshalling error when restoring tabs.
Closed, ResolvedPublic1 Estimated Story Points
Actions