Page MenuHomePhabricator
Create Task
Maniphest T153106

Always request an edit token before page edit
Closed, ResolvedPublic
Actions

Description

The hard-coded, non-authenticated edit token, +\, will go away soon, see T40417.

The apps should always request an edit token before sending the edit request, even when not logged in.

(I'm not sure if the iOS app already does this. I just submitted the same bug for the Android app (T153104) and assume the same is going on in the iOS app.)

Related Objects

Event Timeline

• bearND created this task.Dec 13 2016, 6:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2016, 6:54 PM
• JMinor triaged this task as Low priority.Dec 19 2016, 7:49 PM
• JMinor added projects: iOS-app-v5.4.0-Hiking-Boot, iOS-app-feature-Login.
• JMinor moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.4.0-Hiking-Boot board.Jan 3 2017, 10:29 PM
• JMinor moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v5.4.0-Hiking-Boot board.Jan 5 2017, 7:24 PM
Mhurd claimed this task.Jan 6 2017, 1:01 AM
Mhurd moved this task from Ready for Development to Doing on the iOS-app-v5.4.0-Hiking-Boot board.
• bearND updated the task description. (Show Details)Jan 6 2017, 5:30 PM
Mhurd added a comment.Jan 6 2017, 6:18 PM

https://github.com/wikimedia/wikipedia-ios/pull/1162

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.4.0-Hiking-Boot board.Jan 6 2017, 6:18 PM
JoeWalsh mentioned this in rAPIOScfbcf0ae8b89: Merge branch 'develop' into bug/always-fetch-edit-token/T153106.Jan 10 2017, 3:32 PM
JoeWalsh mentioned this in rAPIOSae612ce44fdc: Merge pull request #1162 from wikimedia/bug/always-fetch-edit-token/T153106.Jan 17 2017, 5:16 PM
Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.4.0-Hiking-Boot board.Jan 17 2017, 6:04 PM
• JMinor moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.4.0-Hiking-Boot board.Jan 24 2017, 7:34 PM
• JMinor closed this task as Resolved.Mar 2 2017, 11:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits