Height ratio for reference card on landscape view is off
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmadeo
	Dec 14 2016, 12:12 AM

Description

The height ratio for the reference card on landscape view is currently shorter than its original design.
Height should be .6

Testing criteria:

On iPhone 6 Plus load the "Cat" article
Rotate phone to landscape
Tap the first reference "[1]" and ensure the reference panel looks like the first image below, not the second image:

Screen Shot 2016-12-14 at 3.01.09 PM.png (884×1 px, 221 KB)

Screen Shot 2016-12-14 at 2.58.47 PM.png (884×1 px, 190 KB)

Repeat steps above with iPhone 6

Related Objects

Mentioned In: rAPIOSf5d8c3abb44c: Merge pull request #1117 from wikimedia/bug/ref-panel-height/T153154

Event Timeline

cmadeo created this task.Dec 14 2016, 12:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2016, 12:12 AM

cmadeo added a subscriber: Mhurd.Dec 14 2016, 12:13 AM

https://github.com/wikimedia/wikipedia-ios/pull/1117

Mhurd claimed this task.Dec 14 2016, 12:23 AM

Mhurd added a project: iOS-app-v5.4.0-Hiking-Boot.

Mhurd moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.4.0-Hiking-Boot board.

JoeWalsh mentioned this in rAPIOSf5d8c3abb44c: Merge pull request #1117 from wikimedia/bug/ref-panel-height/T153154.Dec 14 2016, 11:19 AM

Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.4.0-Hiking-Boot board.Dec 14 2016, 10:48 PM

Mhurd updated the task description. (Show Details)Dec 14 2016, 11:03 PM

Mhurd moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v5.4.0-Hiking-Boot board.

Mhurd moved this task from Needs Design Review to Needs QA on the iOS-app-v5.4.0-Hiking-Boot board.Dec 15 2016, 8:39 PM

Mhurd added a project: iOS-app-Bugs.Dec 15 2016, 11:01 PM

• JMinor triaged this task as Medium priority.Dec 19 2016, 7:48 PM

• JMinor lowered the priority of this task from Medium to Low.

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Testing on iPhone 6s (iOS 10.1.1) and Wikipedia app 5.3.3 (1037).

This is fixed on the iPhone 6s

T153154 iPhone 6s.PNG (750×1 px, 291 KB)

I don't have an iPhone 6 with me - @JMinor there is an iPhone 6 at the Arc office, but I'm working from home right now. Andy said he would go down to the Arc office to get it if it helps with closing this.

@Nicholas.tsg not necessary. I have a 6 here, and just verified this is fixed there as well.

• JMinor moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.4.0-Hiking-Boot board.Dec 20 2016, 7:46 PM

• JMinor closed this task as Resolved.Feb 24 2017, 9:12 PM

	F5056449: Screen Shot 2016-12-14 at 3.01.09 PM.png
	Dec 14 2016, 11:03 PM

	F5056450: Screen Shot 2016-12-14 at 2.58.47 PM.png
	Dec 14 2016, 11:03 PM

	F5111911: IMG_1280.PNG
	Dec 20 2016, 7:45 PM

	F5111815: T153154 iPhone 6s.PNG
	Dec 20 2016, 7:28 PM

Height ratio for reference card on landscape view is offClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Height ratio for reference card on landscape view is off
Closed, ResolvedPublic
Actions