Page MenuHomePhabricator

Using an apostrophe in search inside an article causes the remainder of the string after the apostrophe to not be recognized
Closed, ResolvedPublic

Assigned To
Authored By
cmadeo
Jan 5 2017, 6:28 PM
Referenced Files
F5352970: catscradle4.PNG
Jan 25 2017, 12:06 AM
F5352969: catscradle2.PNG
Jan 25 2017, 12:06 AM
F5352972: catscradle1.PNG
Jan 25 2017, 12:06 AM
F5352971: catscradle3.PNG
Jan 25 2017, 12:06 AM
F5237054: IMG_0113.PNG
Jan 5 2017, 6:28 PM
F5237053: IMG_0114.PNG
Jan 5 2017, 6:28 PM

Description

Steps to reproduce
Go to the String figures article. Open search inside article. Search for cat. Search for cat's cradle.

Expected results
Searching for 'cat' should highlight all instances of the word 'cat' in the article. Searching for 'cat's cradle' should highlight all instances of the term 'cat's cradle' in the article and update the number of search results in the article if there are fewer instances of 'cat's cradle' then 'cats'.

Actual results

Searching for catSearching for cat's cradle
IMG_0113.PNG (1×750 px, 264 KB)
IMG_0114.PNG (1×750 px, 266 KB)

Searching for 'cat' highlights all instances of the word 'cat,' however after adding the apostrophe to begin writing out 'cat's cradle' the search results freeze. Only instances of the word 'cat' are highlighted.

This does not appear to happen with any other punctuation.

Event Timeline

Device details
Model : iPhone 7
iOS 10.2
App version : Wikipedia 5.3.4 (1046)

I'll test this again when TestFlight is fixed (it has been down awhile).

This is still a flaw as seen in the screencaps I've taken

catscradle1.PNG (1×750 px, 809 KB)

catscradle3.PNG (1×750 px, 312 KB)

catscradle4.PNG (1×750 px, 305 KB)

catscradle2.PNG (1×750 px, 284 KB)

So far this looks good on the latest build. In the example article it performed the search correctly.

Device details
Model : iPad Mini Retina
iOS 10.2
App version : Wikipedia 5.3.4 (1053)