Page MenuHomePhabricator

Clean up styles and improve the non-JS version
Closed, ResolvedPublic

Description

Kudos to @TheDJ for catching this, and furthermore proposing a patch to fix it:

  • properly divide into agnostic vs client-js vs client-nojs
  • remove duplicate display:block; on mw-graph-layover
  • hide all layover content (play button, title, loader) when we don't have JS.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2017, 12:42 AM

Change 331910 had a related patch set uploaded (by JGirault):
Graph: cleanup styles a bit

https://gerrit.wikimedia.org/r/331910

JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Jan 27 2017, 12:49 AM
JGirault moved this task from Needs review to Done on the Maps-Sprint board.

Change 331910 merged by jenkins-bot:
Graph: cleanup styles a bit

https://gerrit.wikimedia.org/r/331910

JGirault reassigned this task from JGirault to TheDJ.Jan 27 2017, 1:24 AM
TheDJ closed this task as Resolved.May 17 2017, 11:36 AM
TheDJ removed a project: Patch-For-Review.

This seems resolved to me...