Maniphest T156443

Clean up styles and improve the non-JS version
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JGirault
	Jan 27 2017, 12:42 AM

Tags

Referenced Files

None

Subscribers

Description

Kudos to @TheDJ for catching this, and furthermore proposing a patch to fix it:

properly divide into agnostic vs client-js vs client-nojs
remove duplicate display:block; on mw-graph-layover
hide all layover content (play button, title, loader) when we don't have JS.

Details

	Subject	Repo	Branch	Lines +/-
	Graph: cleanup styles a bit	mediawiki/extensions/Graph	master	+65 -59

Customize query in gerrit

Event Timeline

• JGirault created this task.Jan 27 2017, 12:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2017, 12:42 AM

Change 331910 had a related patch set uploaded (by JGirault):
Graph: cleanup styles a bit

https://gerrit.wikimedia.org/r/331910

gerritbot added a project: Patch-For-Review.Jan 27 2017, 12:46 AM

• JGirault moved this task from Backlog to Needs review on the Maps-Sprint board.Jan 27 2017, 12:49 AM

• JGirault moved this task from Needs review to Done on the Maps-Sprint board.

Change 331910 merged by jenkins-bot:
Graph: cleanup styles a bit

https://gerrit.wikimedia.org/r/331910

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 27 2017, 1:00 AM

• JGirault reassigned this task from • JGirault to TheDJ.Jan 27 2017, 1:24 AM

This seems resolved to me...