Page MenuHomePhabricator

ores logspam: Model contains an error
Closed, ResolvedPublic

Description

This is logged with level ERROR but @Halfak tells me it's normal/expected, therefore it should be logged at the INFO level.

Example log line:

typelevelwikihostmessage
mediawikiERRORenwikimw1234Model contains an error for 594792371: TextDeleted: Text deleted (datasource.revision.text)
{
    "function": "Closure$ORES\\Cache::__construct",
    "args": ["string", "integer"]
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/extensions/ORES/includes/Cache.php",
    "line": 130,
    "function": "call_user_func",
    "args": ["Closure$ORES\\Cache::__construct;1421012988", "string", "integer"]
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/extensions/ORES/includes/ApiHooks.php",
    "line": 288,
    "function": "processRevision",
    "class": "ORES\\Cache",
    "type": "->",
    "args": ["array", "integer", "array"]
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/extensions/ORES/includes/ApiHooks.php",
    "line": 212,
    "function": "loadScoresForRevisions",
    "class": "ORES\\ApiHooks",
    "type": "::",
    "args": ["array"]
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/Hooks.php",
    "line": 186,
    "function": "onApiQueryBaseAfterQuery",
    "class": "ORES\\ApiHooks",
    "type": "::",
    "args": ["ApiQueryContributions", "ResultWrapper", "array"]
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/api/ApiQueryBase.php",
    "line": 387,
    "function": "run",
    "class": "Hooks",
    "type": "::",
    "args": ["string", "array"]
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/api/ApiQueryUserContributions.php",
    "line": 143,
    "function": "select",
    "class": "ApiQueryBase",
    "type": "->",
    "args": ["string", "array", "array"]
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/api/ApiQuery.php",
    "line": 251,
    "function": "execute",
    "class": "ApiQueryContributions",
    "type": "->",
    "args": []
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/api/ApiMain.php",
    "line": 1536,
    "function": "execute",
    "class": "ApiQuery",
    "type": "->",
    "args": []
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/api/ApiMain.php",
    "line": 543,
    "function": "executeAction",
    "class": "ApiMain",
    "type": "->",
    "args": []
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/api/ApiMain.php",
    "line": 514,
    "function": "executeActionWithErrorHandling",
    "class": "ApiMain",
    "type": "->",
    "args": []
}, {
    "file": "/srv/mediawiki/php-1.29.0-wmf.9/api.php",
    "line": 83,
    "function": "execute",
    "class": "ApiMain",
    "type": "->",
    "args": []
}, {
    "file": "/srv/mediawiki/w/api.php",
    "line": 3,
    "function": "include",
    "args": ["string"]
}

Event Timeline

mmodell created this task.Feb 2 2017, 10:06 PM
Restricted Application added a project: Scoring-platform-team. · View Herald TranscriptFeb 2 2017, 10:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mmodell triaged this task as High priority.Feb 2 2017, 10:06 PM

That's somewhat weird, because we score edits once they are made and they shouldn't be deleted ten seconds after they made. Unless the new api.php functionality is not considering the deleted status. I look into it.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 2 2017, 11:29 PM

In this case, the parent revision was deleted. Could have been saved years ago.

If the parent revision gets the deleted, you can't make an edit on top of it. Except the article is deleted and you re-making it (which I'm not sure mediawiki consider them as parent and child)

Woops. I was thinking of a previous example. This text has been deleted. https://en.wikipedia.org/wiki/?oldid=594792371

This edit was saved in 2014!

@Ladsgroup you can delete the parent revision after the child was saved.

Yes, but we finish the scoring around ten seconds after the edit (child) is made. It's very unlikely.

Here's the edit and it's deletion event: https://quarry.wmflabs.org/query/15994

Change 335959 had a related patch set uploaded (by Ladsgroup):
Make API not fail when edit is deleted or can't be scored

https://gerrit.wikimedia.org/r/335959

Change 335959 merged by jenkins-bot:
Make API not fail when edit is deleted or can't be scored

https://gerrit.wikimedia.org/r/335959

Ladsgroup closed this task as Resolved.Feb 6 2017, 7:12 AM
Ladsgroup moved this task from Blocked on others to Done on the User-Ladsgroup board.
Ladsgroup moved this task from Active to Done on the Scoring-platform-team (Current) board.

Thank you for this.