Page MenuHomePhabricator

MW OpenStackManager: add support for ED25519 SSH keys
Closed, ResolvedPublic


I was trying to add an ED25519 SSH key to my Wikitech account on and I got this error:

The provided SSH key was wrong or in unknown format.

From a quick look at the code the message is mapped to the openstackmanager-keypairformatwrong localized message, that in turns is raised in because of the failed check few lines above:

if ( !preg_match( '/(^| )ssh-(rsa|dss) /', $key ) ) {

Is there any reason to filter out ssh-ed25519 keys?
Are they not supported beside this regex check?

On a side not we should consider not accepting anymore the weak DSA ssh-dss keys, they are disabled by default in OpenSSH 7.0+.

Event Timeline

@Volans it doesn't look like ed25519 was intentionally un supported, see which is from 5 years ago. So we could just add ed25519 to the check.

Change 339957 had a related patch set (by Paladox) published:
Add support for ED25519 ssh key

The check was introduced by @Platonides in 24fb4ecdb03b053c891d89b7ba6104753a9c1366. @Platonides: It looks like there was no deeper rationale behind the restriction on ssh-rsa/ssh-dss except that those were the keys in use at that time?

I believe @MoritzMuehlenhoff should have an overview if there are sshds in Labs that cannot deal with ssh-ed25519 keys.

What is the worst that could happen? A user can't log into an instance and has to upload another key?

Change 339957 merged by jenkins-bot:
Add support for ED25519 ssh key

As noted in the commit message, it was a check just to verify that the key was in openssh format, after some people pasting keys in PuTTY format, which led to complex troubleshooting.
This commit dates from Mar 8 2012. ed25519 keys were added on December 2013.

I have approved Paladox commit. I will follow-up adding support to ecdsa, too.

Change 340026 had a related patch set (by Paladox) published:
Remove support for ssh-dsa ssh keys

@scfc: All SSH daemons in labs have fully-featured support for ed25519 (even the remaining precise instances run a backport of openssh from trusty)

Change 340026 abandoned by Paladox:
Remove support for ssh-dsa ssh keys

Closing as resolved as this should now work. Please re open if it does not.