As part of the deployment of MediaWiki-extensions-Linter to Wikimedia wikis, can the underlying table be made available on labs? It doesn't contain any non-private data, and was explicitly OK'd by the security team: T148583#2854927.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Create view for "linter" table on Labs | operations/puppet | production | +1 -0 |
Related Objects
- Mentioned In
- T162898: have txt export for LintErrors
- Mentioned Here
- T148583: Security review for Linter extension
Event Timeline
> describe linter; +---------------+------------------+------+-----+---------+----------------+ | Field | Type | Null | Key | Default | Extra | +---------------+------------------+------+-----+---------+----------------+ | linter_id | int(10) unsigned | NO | PRI | NULL | auto_increment | | linter_page | int(10) unsigned | NO | MUL | NULL | | | linter_cat | int(10) unsigned | NO | MUL | NULL | | | linter_start | int(10) unsigned | NO | | NULL | | | linter_end | int(10) unsigned | NO | | NULL | | | linter_params | blob | NO | | NULL | | +---------------+------------------+------+-----+---------+----------------+ 6 rows in set (0.00 sec)
Consent given in T148583#2854927 by Security. There is nothing here that references a user so there should not be any concern by WMF-Legal.
We need a check from the DBA's to ensure that the table is being replicated and then an addition to https://phabricator.wikimedia.org/diffusion/OPUP/browse/production/modules/role/templates/labs/db/views/maintain-views.yaml to expose the table.
The table is already replicated to labs, we'd only need the view to be created.
mysql:root@localhost [enwiki]> select @@hostname; +------------+ | @@hostname | +------------+ | labsdb1001 | +------------+ 1 row in set (0.00 sec) mysql:root@localhost [enwiki]> show tables like 'linter'; +---------------------------+ | Tables_in_enwiki (linter) | +---------------------------+ | linter | +---------------------------+ 1 row in set (0.00 sec)
mysql:root@localhost [enwiki]> select @@hostname; +------------+ | @@hostname | +------------+ | labsdb1009 | +------------+ 1 row in set (0.00 sec) mysql:root@localhost [enwiki]> show tables like 'linter'; +---------------------------+ | Tables_in_enwiki (linter) | +---------------------------+ | linter | +---------------------------+ 1 row in set (0.00 sec)
Change 348201 had a related patch set uploaded (by Legoktm):
[operations/puppet@production] Create view for "linter" table on Labs
Change 348201 merged by Andrew Bogott:
[operations/puppet@production] Create view for "linter" table on Labs
I merged the puppet change. Next we need to update things with
maintain-views --all-databases --table linter --debug --replace-all
on labsdb1001, 1003, 1009, 1010, 1011
However, there's a bug of some sort that requires intervention from the dbas: pymysql.err.OperationalError: (1044, "Access denied for user 'maintainviews'@'localhost' to database 'dtywiki_p'")
so, waiting for them to be available.