Page MenuHomePhabricator

Suggestions for articles written in Cyrillic don't show up in search when typing in Latin and vice versa on the Serbian Wikipedia
Closed, ResolvedPublic

Description

Steps to Reproduce:

  1. Go to https://sr.wikipedia.org
  2. Click on the search box
  3. Type in "Mesečina (film iz 2016)"

Actual Results:
There are no suggestions.

Expected Results:
The page "Месечина (филм из 2016)" should have been suggested.

If you press Return after typing "Mesečina (film iz 2016)" in the search box, you will be presented with the page "Месечина (филм из 2016)".

The suggestions did work previously, so I'm guessing there was a recent change to the way search works that broke it.

Event Timeline

Srdjan renamed this task from Suggestions for articles written in Cyrillic don't show up in search when typing in Latin and vise-versa on the Serbian Wikipedia to Suggestions for articles written in Cyrillic don't show up in search when typing in Latin and vice versa on the Serbian Wikipedia.Mar 20 2017, 11:08 AM
Nemo_bis subscribed.

I confirm I can reproduce. Sounds related to the work on diacritics, doesn't it?

More likely this is related to the elasticsearch 5 upgrade. The completion suggester had a big overhaul inside elasticsearch for v5, so we've also had to update the code our our side. Theres probably a bug in there somewhere with redirects, sill dig into it.

EBernhardson added subscribers: Arthur2e5, Stang.

Verified with serbian wiki that it's not a redirects problem, as there is no page at Mesečina (film iz 2016). This looks to be something with auto-language conversions as suggested in T160919

Change 343673 had a related patch set uploaded (by EBernhardson):
[mediawiki/extensions/CirrusSearch] Don't pass null suggest queries to elasticsearch

https://gerrit.wikimedia.org/r/343673

Change 343673 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch] Don't pass null suggest queries to elasticsearch

https://gerrit.wikimedia.org/r/343673

Change 343744 had a related patch set uploaded (by EBernhardson):
[mediawiki/extensions/CirrusSearch] Don't pass null suggest queries to elasticsearch

https://gerrit.wikimedia.org/r/343744

Change 343744 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch] Don't pass null suggest queries to elasticsearch

https://gerrit.wikimedia.org/r/343744

Mentioned in SAL (#wikimedia-operations) [2017-03-20T23:58:40Z] <dereckson@tin> Synchronized php-1.29.0-wmf.16/extensions/CirrusSearch/includes/CompletionSuggester.php: Don't pass null suggest queries to elasticsearch (T160896) (duration: 00m 42s)

This should be fixed tomorrow when the completion suggester is re-enabled