Page MenuHomePhabricator

Transclusion dialog tries to submit invalid titles when enter is pressed
Closed, ResolvedPublic1 Story Points

Description

Attempting to write a non-valid Title into the Add Template dialog, e.g. #tag, will correctly disable the "add template" button, but pressing enter with the focus in the input will still attempt to add the template. This will fail with a JS error, because it tries to create a mw.Title from null.

Event Timeline

DLynch created this task.Mar 29 2017, 3:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2017, 3:53 PM

Change 345385 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor@master] Add template: don't try to add invalid templates when enter is pressed

https://gerrit.wikimedia.org/r/345385

Jdforrester-WMF closed this task as Resolved.Mar 29 2017, 3:56 PM
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 29 2017, 3:56 PM

Change 345385 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add template: don't try to add invalid templates when enter is pressed

https://gerrit.wikimedia.org/r/345385