Page MenuHomePhabricator
Create Task
Maniphest T161715

Transclusion dialog tries to submit invalid titles when enter is pressed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Attempting to write a non-valid Title into the Add Template dialog, e.g. #tag, will correctly disable the "add template" button, but pressing enter with the focus in the input will still attempt to add the template. This will fail with a JS error, because it tries to create a mw.Title from null.

Details

SubjectRepoBranchLines +/-
Add template: don't try to add invalid templates when enter is pressedmediawiki/extensions/VisualEditormaster+7 -2
Customize query in gerrit

Event Timeline

DLynch created this task.Mar 29 2017, 3:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2017, 3:53 PM
gerritbot subscribed.Mar 29 2017, 3:54 PM

Change 345385 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor@master] Add template: don't try to add invalid templates when enter is pressed

https://gerrit.wikimedia.org/r/345385

gerritbot added a project: Patch-For-Review.Mar 29 2017, 3:54 PM
Jdforrester-WMF closed this task as Resolved.Mar 29 2017, 3:56 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Templates; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 29 2017, 3:56 PM
gerritbot added a comment.Mar 29 2017, 4:39 PM

Change 345385 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add template: don't try to add invalid templates when enter is pressed

https://gerrit.wikimedia.org/r/345385

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Mar 29 2017, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL