If reviewed page was deleted and then undeleted, page is marked both as reviewed and non-reviewed
Open, Needs TriagePublic

Description

If reviewed pages were deleted and then undeleted, then something strange happened: it is marked both as reviewed and non-reviewed. Example: https://ru.wikipedia.org/w/index.php?title=%D0%90%D0%BB%D0%B5%D0%BA%D1%81%D0%B0%D0%BD%D0%B4%D1%80_%D0%A0%D0%B0%D1%84%D0%B0%D0%B8%D0%BB%D0%BE%D0%B2%D0%B8%D1%87_%D0%9A%D0%BE%D1%80%D1%81%D1%83%D0%BD%D1%81%D0%BA%D0%B8%D0%B9&redirect=no

Now this redirect page looks OK, but only after unreview and then again review action.

New example: https://ru.wikipedia.org/w/index.php?title=%D0%90%D0%BB%D0%B5%D0%BA%D1%81%D0%B5%D0%B9_%D0%9C%D0%B8%D1%85%D0%B0%D0%B9%D0%BB%D0%BE%D0%B2%D0%B8%D1%87_%D0%9F%D1%80%D0%BE%D0%BA%D0%B8%D0%BD&redirect=no

The problem is that after restoring reviewed page, FlaggedRevs::newFromTitle returns NULL. I can not figure out why

It is the same not only for redirects, but for all pages, in all namespaces.

Choomaq created this task.Apr 12 2017, 8:35 AM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptApr 12 2017, 8:35 AM
Choomaq updated the task description. (Show Details)Apr 12 2017, 8:41 AM
Aklapper renamed this task from Bug: if reviewed pages were deleted and then undeleted to If reviewed page was deleted and then undeleted, page is marked both as reviewed and non-reviewed.Apr 12 2017, 1:09 PM
Choomaq updated the task description. (Show Details)Apr 14 2017, 1:37 PM
Arbnos added a subscriber: Arbnos.Apr 18 2017, 10:35 PM
Eugene added a subscriber: Eugene.EditedMay 2 2017, 1:57 PM

I can not reproduce the problem. In my local wiki (on my machine: MediaWiki 1.30.0-alpha (fb36b7d) PHP 5.5.38 (apache2handler) MariaDB 10.1.22-MariaDB, Flagged Revisions – (aa44500) ) I reviewed a page, then deleted it and restored it. Everything seems to be fine. Can somebody (@Choomaq @MaxBioHazard @Arbnos ) tell me step by step how to reproduce this bug