Page MenuHomePhabricator
Create Task
Maniphest T163055

FloatingMenuSelectWidget with an overlay jumps to the position of the overlay if an item is selected
Closed, ResolvedPublic
Actions

Description

I can reproduce this in Firefox 52.0.2 and Chromium 57.0.2987.98.

To reproduce:

  1. Open the demo page.
  2. Find the "DropdownWidget (using overlay)‎" demo.
  3. Select one of the options in the widget.
  4. Click the widget again.
    • At this point, it will jump to the top of the page.

This seems to have been caused by rGOJUc40a55f1ecb5: MenuSelectWidget: Ensure currently selected element is visible when menu opens which added a scrollElementIntoView() call into MenuSelectWidget in a place that gets called before FloatingMenuSelectWidget positions the dropdown on screen, The comment here seems apropos.

I don't know if it's the best solution, but I find that sticking that scrollElementIntoView inside a 0-delay setTimeout() fixes it.

Details

SubjectRepoBranchLines +/-
[DEPRECATING CHANGE] Merge functionality of FloatingMenuSelectWidget into MenuSelectWidgetoojs/uimaster+48 -74
MenuSelectWidget: Workaround for scrolling to top of page for dropdowns with $overlayoojs/uimaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.Apr 15 2017, 10:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2017, 10:31 PM
matmarex added a comment.Apr 18 2017, 7:49 PM

Yeah, this is a mess. I don't know what the best solution is either, but your proposed workaround seems okay.

gerritbot subscribed.Apr 18 2017, 7:54 PM

Change 348799 had a related patch set uploaded (by Bartosz Dziewoński):
[oojs/ui@master] MenuSelectWidget: Workaround for scrolling to top of page for dropdowns with $overlay

https://gerrit.wikimedia.org/r/348799

gerritbot added a project: Patch-For-Review.Apr 18 2017, 7:54 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Apr 25 2017, 8:19 PM
gerritbot added a comment.Apr 26 2017, 8:32 PM

Change 350479 had a related patch set uploaded (by Bartosz Dziewoński):
[oojs/ui@master] Merge functionality of FloatingMenuSelectWidget into MenuSelectWidget

https://gerrit.wikimedia.org/r/350479

gerritbot added a comment.Apr 26 2017, 8:33 PM

Change 348799 abandoned by Bartosz Dziewoński:
MenuSelectWidget: Workaround for scrolling to top of page for dropdowns with $overlay

Reason:
See https://gerrit.wikimedia.org/r/350479 for a proper solution.

https://gerrit.wikimedia.org/r/348799

gerritbot added a comment.Apr 27 2017, 9:37 PM

Change 350479 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] Merge functionality of FloatingMenuSelectWidget into MenuSelectWidget

https://gerrit.wikimedia.org/r/350479

matmarex closed this task as Resolved.May 29 2017, 5:27 PM
matmarex claimed this task.
matmarex edited projects, added OOUI (OOjs-UI-0.21.3); removed Patch-For-Review, OOUI.
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL