Steps to reproduce:
Expected behavior:
After Quarry is openned, I'm still logged in. I'm used to this behavior e.g. from Phabricator, which remembers my login.
Current behavior:
After Quarry is openned, I'm logged out as Quarry doesn't remember my login.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Set session.permanent = True when user is logged in | analytics/quarry/web | master | +1 -0 |
Cause: The HTTP response header for cookies on quarry is:
Set-Cookie: session=REDACTED; HttpOnly; Path=/
It does not specify an expiry and as a result it expires 'at end of session' (i.e. browser closed).
Change 368745 had a related patch set uploaded (by Zhuyifei1999; owner: Zhuyifei1999):
[analytics/quarry/web@master] Set session.permanent = True when user is logged in
Change 368745 merged by jenkins-bot:
[analytics/quarry/web@master] Set session.permanent = True when user is logged in
Mentioned in SAL (#wikimedia-cloud) [2017-08-01T12:51:42Z] <zhuyifei1999_> Deployed ba54a61 on quarry-main-01 T164390
It should now remember login for 31 days (default). If this is too long or too short, or if a "remember my login" checkbox should be added, please reopen.