Page MenuHomePhabricator

Book creator interface from Collection extension should not use "Sitenotice" mechanism
Open, Needs TriagePublic


Using sitenotice for any messages other than the actual sitenotice is a really bad idea: when the user hides a sitenotice, any other messages, like the Collection toolbar, are hidden and not showable without undoing the sitenotice hide. I’m not sure if it even has to be above the page title, it might be moved to #contentSub (just below the tagline), or even to the bottom of the page or to the toolbar (where there is already a disable button).

Event Timeline

Could you clarify which code base needs a change here?

The Collection extension is needed to be modified, but I’m not familiar with the code so I can’t say it more exactly.

Krinkle renamed this task from Do not use sitenotice for Collection messages to Book creator interface from Collection extension should not use "Sitenotice" mechanism.May 27 2019, 6:55 PM

This is about the following interface, which the Collection extension injects at the top of every article if the current user has an unfinished "book" collection that they started on Special:Book.

Screenshot 2019-05-27 at 19.55.31.png (500×2 px, 135 KB)

The code for that is in mediawiki-extensions-Collections.git:/includes/CollectionHooks.php#siteNoticeAfter.