Page MenuHomePhabricator

Fix UtilityOnlineTest in backend
Closed, ResolvedPublic

Description

The failing UtilityOnlineTest holds back the merging of https://github.com/wmde/fundraising-backend/pull/253 which is needed for T163695. The test itself is problematic:

  • It assumes the existence of the application being deployed on a web server on port 80.
  • It is more of an "Edge to Edge" test than an "Integration" test.

We need to decide how to proceed. At the moment there are two options on the table:

  • Just delete the test because it tests the wrong things.
  • Start to use Silex for routing:
    • Add a route for '/util/status/check'
    • Rewrite UtilityOnlineTest as a Silex WebRouteTest.
    • Use the current "Router" (Fundraiser class) and Request construction in the Silex 404 error handling as a fallback for routes that have not been converted.
    • Whenever we touch a route, we replace the controller class with a Silex route and add an edge-to-edge test for the controller.

Event Timeline

gabriel-wmde claimed this task.

At the story time we decided to split this issue into two tasks: A short term solution for the next sprint (T164747) and a long-term plan for refactoring the backend application (T164752)