Page MenuHomePhabricator
Create Task
Maniphest T164751

mass adding of jakub-onderka/php-console-highlighter missed changes to composer.lock files
Closed, ResolvedPublic
Actions

Description

At least the AWSSDK repository now gives an composer.lock error, because the change rEAWK8a394dd0e82a39aa451fd1ba4aba1a1dc7fda974 only updates the composer.json, not the also commited composer.lock file.

20:00:25 + composer --ansi validate --no-check-publish
20:00:28 ./composer.json is valid, but with a few warnings
20:00:28 See https://getcomposer.org/doc/04-schema.md for details on the schema
20:00:28 The lock file is not up to date with the latest changes in composer.json, it is recommended that you run composer update.
20:00:28 No license specified, it is recommended to do so. For closed-source software you may use "proprietary" as license.

Please check all repositories with composer.lock file, if the lock file needs changes to unbreak CI

Details

SubjectRepoBranchLines +/-
Delete outdated composer.lockmediawiki/extensions/AWSmaster+0 -383
Remove committed vendor foldermediawiki/extensions/AWSSDKmaster+4 -161 K
Delete outdated composer.lockmediawiki/extensions/Cardsmaster+0 -179
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.May 8 2017, 3:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2017, 3:02 PM
Umherirrender renamed this task from mass adding of jakub-onderka/php-console-highlighter missed composer.lock files to change to mass adding of jakub-onderka/php-console-highlighter missed changes to composer.lock files.May 8 2017, 3:03 PM
gerritbot subscribed.May 8 2017, 3:25 PM

Change 352603 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/AWSSDK@master] Remove committed vendor folder

https://gerrit.wikimedia.org/r/352603

gerritbot added a project: Patch-For-Review.May 8 2017, 3:25 PM
hashar added a comment.May 8 2017, 7:21 PM

I have definitely havent updated composer.lock at all, sorry.

It seems the AWSSDK extension is meant to provide some dependencies that are available on packagist.org. Nowadays with MediaWiki supporting composer install of dependencies, I am not sure how needed that is. Maybe it can be dished out.

• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.May 9 2017, 10:07 AM
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
• Qse24h closed this task as a duplicate of T164723: New git repository: <repo name>.
Aklapper reopened this task as Open.May 9 2017, 10:19 AM
Umherirrender added a comment.May 9 2017, 6:05 PM

I have run composer validate locally on all extensions of mediawiki/extensions

The following repos are effected:

  • AWS
  • AWSSDK
  • Cards

Please fix the test runs there.

Umherirrender added a comment.May 9 2017, 6:08 PM

For information: DonationInterface is the last repo with php-lint missing jakub-onderka/php-console-highlighter.
It also have a composer.lock. Would be nice to see a patch set there. Thanks.

gerritbot added a comment.May 17 2017, 5:18 PM

Change 354130 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Cards@master] Delete outdated composer.lock

https://gerrit.wikimedia.org/r/354130

gerritbot added a comment.May 17 2017, 7:11 PM

Change 354130 merged by jenkins-bot:
[mediawiki/extensions/Cards@master] Delete outdated composer.lock

https://gerrit.wikimedia.org/r/354130

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 17 2017, 8:00 PM
gerritbot added a comment.May 21 2017, 10:07 AM

Change 352603 merged by jenkins-bot:
[mediawiki/extensions/AWSSDK@master] Remove committed vendor folder

https://gerrit.wikimedia.org/r/352603

hashar assigned this task to Umherirrender.May 31 2017, 4:34 PM
hashar removed a project: Continuous-Integration-Infrastructure.
hashar moved this task from Backlog to In progress on the Continuous-Integration-Config board.
gerritbot added a comment.Jun 3 2017, 10:54 AM

Change 357008 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/AWS@master] Delete outdated composer.lock

https://gerrit.wikimedia.org/r/357008

gerritbot added a comment.Jun 6 2017, 11:49 AM

Change 357008 merged by jenkins-bot:
[mediawiki/extensions/AWS@master] Delete outdated composer.lock

https://gerrit.wikimedia.org/r/357008

hashar closed this task as Resolved.Jun 6 2017, 12:02 PM

AWSSDK should be emptied / archived. I have filled T167124 for that.

Looks like all repositories are fine now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits