Page MenuHomePhabricator

Scrolling window causes JS error
Closed, ResolvedPublic1 Estimated Story Points

Description

Sometimes scrolling the VE view causes this error to appear:

VM1039:formatted:13548 Uncaught TypeError: target.scrollTo is not a function
    at VeInitMwMobileFrontendArticleTarget.ve.init.mw.MobileFrontendArticleTarget.onWindowScroll (<anonymous>:421:678)
    at later (load.php?debug=false&lang=en&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2Cdiffing%2Cmwcor…:1052)

Seems to be a side effect of 8b1208cb976278bd44025e6d2c86a3ea6ed8c177.

Event Timeline

DLynch created this task.May 11 2017, 4:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2017, 4:39 PM

Change 353328 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/MobileFrontend@master] Fix scrolling calls to VE core

https://gerrit.wikimedia.org/r/353328

Change 353328 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix scrolling calls to VE core

https://gerrit.wikimedia.org/r/353328

Jdforrester-WMF closed this task as Resolved.May 11 2017, 9:49 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Epics on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 11 2017, 9:49 PM