Page MenuHomePhabricator
Create Task
Maniphest T166478

Missing Summary: $1 is not replaced properly
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Per https://gerrit.wikimedia.org/r/#/c/348748 same messages were changed: hardcoded {{int:savearticle}} was replaced by $1.

Sadly this does not work properley. Tested on a local testwiki (master branch), $1 is replaced with the literal message name „savechanges“

save changes old editor.PNG (361×1 px, 27 KB)
and (tested on dewiki) in VisualEditor $1 is still shown
save changes Visual Editor.PNG (634×513 px, 34 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+9 -9EditPage: Fix passing the save/publish button label to other messages
mediawiki/extensions/VisualEditormaster+5 -1VisualEditorDataModule: Pass save/publish button label to 'missingsummary' message
Customize query in gerrit

Event Timeline

Raymond created this task.May 28 2017, 6:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 28 2017, 6:52 PM
matmarex claimed this task.May 29 2017, 6:41 PM
matmarex added projects: VisualEditor-MediaWiki, MediaWiki-Page-editing.
Aklapper renamed this task from Missung Summary: $1 is not replaced properley to Missing Summary: $1 is not replaced properly.May 29 2017, 6:45 PM
gerritbot added a subscriber: gerritbot.May 29 2017, 7:16 PM

Change 356077 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Fix passing the save/publish button label to other messages

https://gerrit.wikimedia.org/r/356077

gerritbot added a project: Patch-For-Review.May 29 2017, 7:16 PM

Change 356078 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] VisualEditorDataModule: Pass save/publish button label to 'missingsummary' message

https://gerrit.wikimedia.org/r/356078

gerritbot added a comment.May 30 2017, 1:32 AM

Change 356078 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] VisualEditorDataModule: Pass save/publish button label to 'missingsummary' message

https://gerrit.wikimedia.org/r/356078

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 30 2017, 2:00 AM
gerritbot added a comment.May 30 2017, 5:48 PM

Change 356077 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Fix passing the save/publish button label to other messages

https://gerrit.wikimedia.org/r/356077

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 30 2017, 6:00 PM
Jdforrester-WMF closed this task as Resolved.May 30 2017, 6:04 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 30 2017, 6:04 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL