ApiFeedContributions date filter broken after T120733
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nemo_bis
	Jun 2 2017, 7:17 AM

Description

T120733 changes ContribsPager to use 'start' and 'end' parameters, rather than 'year' and 'month.' SpecialContributions was modified to convert the legacy 'year' and 'month' options to use the new 'start' and 'end' options, but ApiFeedContributions (the other class to use ContribsPager) was not modified, which breaks action=feedcontributions filtering by year/month.

[Fri Jun  2 08:40:12 2017] [hphp] [2178:7f9ee77ff700:88675:000001] [] \nNotice: Undefined index: start in
                    /srv/mediawiki/tags/2017-06-01_14:16:17/includes/specials/pagers/ContribsPager.php on line 82
[Fri Jun  2 08:40:12 2017] [hphp] [2178:7f9ee77ff700:88675:000002] [] \nNotice: Undefined index: end in
                    /srv/mediawiki/tags/2017-06-01_14:16:17/includes/specials/pagers/ContribsPager.php on line 85

Details

	Subject	Repo	Branch	Lines +/-
	Fix action=feedcontributions date filtering parameters	mediawiki/core	master	+49 -45

Customize query in gerrit

Related Objects

Mentioned Here: T166966: action=feedcontributions should use new date range parameters
T120733: Improve date range searches on Special:Contributions
rMWb66888733c18: Use PHP DateInputWidget in Contribs and use for range filtering

Event Timeline

Nemo_bis created this task.Jun 2 2017, 7:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2017, 7:17 AM

Nemo_bis added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Jun 2 2017, 7:17 AM

Recently merged: b66888733c182fd02478c0d351682b15c3f114df by @Sn1per

Sn1per claimed this task.Jun 3 2017, 12:17 AM

This happens because the changes for T120733 cause ContribsPager to expect 'start' and 'end' options. SpecialContributions converts the old 'date' and 'month' options to 'start' and 'end' options, but ApiFeedContributions (which is the only other class that uses ContribsPager) does not, which breaks ApiFeedContributions date filtering capabilities and causes these notices.

Sn1per renamed this task from Notice: Undefined index start/end in ContribsPager.php to ApiFeedContributions date filter broken after T120733.Jun 3 2017, 4:44 AM

Sn1per edited projects, added Regression, MediaWiki-Action-API; removed MediaWiki-General.

Sn1per updated the task description. (Show Details)

Change 357109 had a related patch set uploaded (by Sn1per; owner: Sn1per):
[mediawiki/core@master] Fix action=feedcontributions date filtering parameters

https://gerrit.wikimedia.org/r/357109

gerritbot added a project: Patch-For-Review.Jun 4 2017, 1:42 AM

The above patch makes action=feedcontributions work again but doesn't change its parameters. I've made a new task (T166966) to deal with actually changing the API action parameters.

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Jun 5 2017, 1:12 PM

Change 357109 merged by jenkins-bot:
[mediawiki/core@master] Fix action=feedcontributions date filtering parameters

https://gerrit.wikimedia.org/r/357109

Sn1per closed this task as Resolved.Jun 6 2017, 3:40 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)).Jun 6 2017, 4:00 PM

• Phabricator_maintenance added a project: affects-translatewiki.net.Sep 26 2019, 1:53 PM

• Phabricator_maintenance removed a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Sep 26 2019, 1:55 PM