Page MenuHomePhabricator

name mainpage and mainpage-description consistently
Closed, DeclinedPublic

Description

with bug 6332 a new variable was introduced, mainpage-description. unfortunately, this is inconsistent with other variables (portal, portal-url, etc.). I suggest correcting this to mainpage as description and mainpage-url as qualified page name.

In order to do this in every Messages*.php a line 'mainpage-url' => $mainpage, has to be added

Moreover, in Title::newMainPage:

  • $title = Title::newFromText( wfMsgForContent( 'mainpage' ) );

+ $title = Title::newFromText( wfMsgForContent( 'mainpage-url' ) );


Version: 1.13.x
Severity: normal

Details

Reference
bz14695

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:13 PM
bzimport set Reference to bz14695.
bzimport added a subscriber: Unknown Object (MLST).

Too much work and would break too many things for only small benefit in naming consistency. I say wontfix.

The naming was chosen to avoid disrupting sites which had customized the main page name.

  • Bug 14848 has been marked as a duplicate of this bug. ***