Page MenuHomePhabricator

throttle.php: Separate the throttling definitions from the exception values itself
Closed, ResolvedPublic

Description

Currently wmgThrottlingExceptions is in the same file as wgExtensionFunctions.

The first is to define the exceptions itself, and the second is to analyze them. I think that we should separate the first that is often edited, and more edited than the second that is a script.

Event Timeline

While its being moved, could T163872 possibly be added?

Change 373695 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] throttle.php: Separate the throttling definitions from the exception values itself

https://gerrit.wikimedia.org/r/373695

While its being moved, could T163872 possibly be added?

I've submited patches for both of those tasks (the patch for T163872 depends on patch for this task, just FYI). There should be no problem with deploying from the technical side of thing.

Change 373695 merged by jenkins-bot:
[operations/mediawiki-config@master] throttle.php: Separate the throttling definitions from the exception values itself

https://gerrit.wikimedia.org/r/373695

Mentioned in SAL (#wikimedia-operations) [2017-08-28T13:33:58Z] <zfilipin@tin> Synchronized wmf-config/throttle-analyze.php: SWAT: [[gerrit:373695|throttle.php: Separate the throttling definitions from the exception values itself (T167040)]] (duration: 00m 44s)

Mentioned in SAL (#wikimedia-operations) [2017-08-28T13:34:57Z] <zfilipin@tin> Synchronized wmf-config/throttle.php: SWAT: [[gerrit:373695|throttle.php: Separate the throttling definitions from the exception values itself (T167040)]] (duration: 00m 44s)

Mentioned in SAL (#wikimedia-operations) [2017-08-28T13:36:09Z] <zfilipin@tin> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:373695|throttle.php: Separate the throttling definitions from the exception values itself (T167040)]] (duration: 00m 44s)