Page MenuHomePhabricator

Different collapsible buttons look inconsistent
Closed, InvalidPublic

Description

There are three different collapsible buttons used on enwiki that I'm aware of: mw-collapsible, collapsible, and NavFrame buttons (the different types are explained in this MediaWiki Wiki manual). Only the former is included in default MediaWiki; I assume the others are kept on enwiki for compatibility purposes.

Nevé–selbert mentioned that the different styles of collapsible button should look the same, and that he thinks the mw-collapsible type should be smaller relative to the text.

If the latter two types are to be retained, I think that they should appear identical to the mw-collapsible type so as not to cause any inconsistencies. If they are to be replaced, then the mw-collapsible type should be able to function identically to the others. Currently the only thing it can't do is be aligned to the left, at least without changing site CSS.

Personally I think the left and right brackets should be kept out of the link (of the NavFrame buttons), so that only "show" or "hide" is blue and the brackets are black (by default). However, I am not sure if this is already the case by default or whether enwiki has a slightly different gadget to mediawikiwiki.

Event Timeline

What is a NavFrame button and where to find that in the MediaWiki (or MediaWiki extensions) code base?

Are NavFrames also supposed to be replaced by mw-collapsible?

That page says MediaWiki version: ≤ 1.18 so I don't think NavFrame is relevant when it comes to MediaWiki code?
Maybe it is relevant though for some Wikimedia web sites out there though?
Hence clarification (and links) welcome in task descriptions to allow others to understand the scope of this task...

@Aklapper I've elaborated the description. I didn't realize that NavFrames were also deprecated (and I didn't know about the mw-collapsible-content class), so maybe the title should be changed?

I assume the others are kept on enwiki for compatibility purposes.

You'd have to ask enwiki for that. :)

If the latter two types are to be retained

I do not know where to see/find the docs for collapsible. If it's also deprecated then there is nothing to retain.

Currently the only thing it can't do is be aligned to the left, at least without changing site CSS.

Is there a dedicated feature request task about that?

You'd have to ask enwiki for that. :)
I do not know where to see/find the docs for collapsible. If it's also deprecated then there is nothing to retain.

In this edit from October 2016, @Redrose64 says in the summary "we're trying to move from collapsible (which is locally defined) to mw-collapsible (which is part of the MediaWiki software)". So I don't think there's anything to retain from it. All three are still currently in use though.

The information is at the bottom of the manual page, although it's not so much documentation as a script. The manual on Meta hasn't been updated to refer to mw-collapsible yet (they appear to function identically except there's an animation in the newer one), but should be accurate.

Is there a dedicated feature request task about that?

Don't think so. Should one be created?

Another difference (to NavFrame) is that there is no way of centring the header text perfectly without an additional div with a margin containing the text (e.g. in Template:Navbox/sandbox; testcases), which is suboptimal since the width of the button can change depending on the font used. However, I'm not sure if doing this is possible without having to do things like position: relative.

Well, it's getting unclear to me what the scope of this task is... :)
Do you request a consistent appearance of items which requires editing code which has been deprecated for years?
Do you request certain functionality in the non-deprecated code ("can't be aligned to the left")?
Do you request migrating from using deprecated button code to maintained button code in on-wiki content?
Do you request updates to the manual on Meta?

At first I didn't realize the code was deprecated, which is why I suggested making them look consistent. I would therefore request the addition of functionality in the new code so that migration from the old code can be achieved. The Meta manual can be copied from the enwiki version. Filing a bug.

Aklapper changed the task status from Resolved to Invalid.Jun 12 2017, 11:51 AM

Nothing got resolved here, hence changing to invalid