Page MenuHomePhabricator

Thumbnail links to individual DjVu pages have two "page" GET parameters
Closed, ResolvedPublic

Description

When including a specific page of a DjVu image, the link to the image description has two "page" GET parameters. The "zoom" symbol links to the correct URL:

http://de.wikipedia.org/w/index.php?title=Bild:Katia.djvu&page=10

The thumbnail links to this URL:

http://de.wikipedia.org/w/index.php?title=Bild:Katia.djvu&page=10&page=10

The same applies to the previous/next page preview on the image description; the thumbnails link to "&page=9&page=9" and "&page=11&page=11" in this example.


I don't have a test wiki at the moment, so I couldn't try to fix this myself. But I found a clue - which might help to at least solve the latter part of the problem - in /includes/ImagePage.php, lines 381-383 (and something similar for $thumb2 in 390-392):

$link = $sk->makeKnownLinkObj( $this->mTitle, $label, 'page='. ($page-1) );
$thumb1 = $sk->makeThumbLinkObj( $this->mTitle, $this->displayImg, $link, $label, 'none',

array( 'page' => $page - 1 ) );

$link already includes "page=...", so the makeThumbLinkObj call contains this information twice. That might explain the duplication.


Version: 1.13.x
Severity: enhancement
URL: http://de.wikipedia.org/w/index.php?title=Benutzer:Dapete/Test&oldid=48194272

Details

Reference
bz14771

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:11 PM
bzimport added a project: MediaWiki-DjVu.
bzimport set Reference to bz14771.
bzimport added a subscriber: Unknown Object (MLST).

(In addition: the first issue is what I fixed. The latter seems like it has already been fixed)