Page MenuHomePhabricator

Add ability for MG to import to Primary address type
Closed, ResolvedPublic4 Estimated Story Points

Description

Support Major Gifts target smart import by adding ability to import to
Primary' address, overwriting the existing primary, if one exists.

https://issues.civicrm.org/jira/browse/CRM-20759

Event Timeline

Change 361807 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] CRM-20759 add ability to import to primary addresses.

https://gerrit.wikimedia.org/r/361807

HI @LeanneS there is code on staging now that should support importing to the primary address

@Eileenmcnaughton Thanks! I've just tested more, and the addresses successfully imported as primary. I noticed though that many imported as international addresses despite including United States for the country. Examples: CID 19905309, 19962195

Also, I tested a few deceased contacts and none of them reflected in the import: CID 1687480, 1851331

Some also appear to not update the old address to Old 2017: CID 480249

Please let me know if you need any additional examples or info.

Change 361807 abandoned by Eileen:
CRM-20759 add ability to import to primary addresses.

Reason:
will redo on upgraded version

https://gerrit.wikimedia.org/r/361807

@Ejegg and @Eileenmcnaughton I just tried testing the latest deploy but the option to select primary address no longer shows up.

I attempted testing on the production site but Contact ID now doesn't show up in the dropdown as a field.

@Ejegg confirmed that he can't see contact ID locally when he tries to undo the change and said that it might have to do with the Civi upgrade. @Eileenmcnaughton could you please investigate?

Thank you!

Also, when creating the new mapping, it highlighted potential errors and shows that birthdate with prevent import. Below is the message from the error log.

Invalid value for field(s) : Birth-Date

Hi All, I ran the test again checking "Update" and was able to import but still saw errors. None of the addresses I put to Old 2017 show as such, and look like they are getting associated as Old 2014. Deceased contacts also aren't being reflected in the import. Also some are still importing as international addresses (CID 489138 and 1687480) and/or separated addresses (CID 1099471). The contacts I imported are all under the tag "TargetSmart Update 2017" for reference and I used the mapping "TargetSmart Update 2017." Please let me know if you need any additional info to move forward with the fixes. Thanks in advance.

Change 367399 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm/civicrm@master] CRM-20953 Importing contacts with deceased_date not setting is_deceased

https://gerrit.wikimedia.org/r/367399

@LeanneS I dug into the weird things you described & put a bug of fixes on staging that seem to work for me. Need some review before I can put on live

Change 367399 merged by jenkins-bot:
[wikimedia/fundraising/crm/civicrm@master] CRM-20953 Importing contacts with deceased_date not setting is_deceased

https://gerrit.wikimedia.org/r/367399

@LeanneS I just deployed a bunch of patches on live too to address the bugs you described

@Eileenmcnaughton thanks, the fixes were reflected and I was able to successfully update the contacts! Really appreciate it.

Eileenmcnaughton set the point value for this task to 4.