Page MenuHomePhabricator

[Dashboards] Fix spline smoothing
Closed, ResolvedPublic2 Estimated Story Points


Spline smoothing in polloi is broken across all dashboards now :( possibly from

Error in ‘+’ only defined for equally-sized data frames

Screen Shot 2017-06-28 at 11.37.12 AM.png (479×1 px, 127 KB)

Event Timeline

mpopov moved this task from Backlog to In progress on the Discovery-Analysis (Current work) board.

Going to work on this while Chelsy takes a look at my progress on- and gives me a hand with T168466.

Change 362107 had a related patch set uploaded (by Bearloga; owner: Bearloga):
[wikimedia/discovery/polloi@master] Fix spline smoothing and add tests

The issue was the mgcv::gam(y ~ mgcv::s(x from the previous patch to polloi instead of mgcv::gam(y ~ s(

I got a little carried away with the patch by also adding unit tests and such to the package, but also it's one of those things that if we had unit tests earlier, we would have known about the problem before the patch was merged. So I feel a little justified in getting carried away ^_^ also I like refactoring old code that I know needs to be refactored and updating documentation :P

Change 362107 merged by Chelsyx:
[wikimedia/discovery/polloi@master] Fix spline smoothing and add tests