Spline smoothing in polloi is broken across all dashboards now :( possibly from https://gerrit.wikimedia.org/r/#/c/360797/5/R/smoothing.R
Error in Ops.data.frame: ‘+’ only defined for equally-sized data frames
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix spline smoothing and add tests | wikimedia/discovery/polloi | master | +412 -163 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Going to work on this while Chelsy takes a look at my progress on- and gives me a hand with T168466.
Comment Actions
Change 362107 had a related patch set uploaded (by Bearloga; owner: Bearloga):
[wikimedia/discovery/polloi@master] Fix spline smoothing and add tests
Comment Actions
The issue was the mgcv::gam(y ~ mgcv::s(x from the previous patch to polloi instead of mgcv::gam(y ~ s(
I got a little carried away with the patch by also adding unit tests and such to the package, but also it's one of those things that if we had unit tests earlier, we would have known about the problem before the patch was merged. So I feel a little justified in getting carried away ^_^ also I like refactoring old code that I know needs to be refactored and updating documentation :P
Comment Actions
Change 362107 merged by Chelsyx:
[wikimedia/discovery/polloi@master] Fix spline smoothing and add tests