Description

I forgot about this TODO:

$status = CheckResult::STATUS_VIOLATION;
// TODO include the other entities in the message                                                                                                                                           
$message = wfMessage( 'wbqc-violation-message-unique-value' )->escaped();

But now that this is actually live on Wikidata, the need for it becomes pretty obvious:

This property's value must not be present on any other item.

Thanks for nothing, violation message…

Details

	Subject	Repo	Branch	Lines +/-
	Include other items in Unique value violation message	mediawiki/extensions/WikibaseQualityConstraints	master	+6 -4

Customize query in gerrit

Related Objects

Duplicates Merged Here: T169623: Add a list of the entities with the same value in the Unique Constraint Violation message
T169186: Include other items with the same value in “Unique value” violation message

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 29 2017, 9:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2017, 9:34 AM

matej_suchanek merged a task: T169186: Include other items with the same value in “Unique value” violation message.Jun 29 2017, 10:43 AM

Change 362234 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Include other items in Unique value violation message

https://gerrit.wikimedia.org/r/362234

gerritbot added a project: Patch-For-Review.Jun 29 2017, 4:35 PM

Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.Jun 29 2017, 4:35 PM

Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.

Lucas_Werkmeister_WMDE moved this task from Backlog to REVIEW on the Wikibase-Quality board.

Lucas_Werkmeister_WMDE moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.

• Jonas closed this task as Resolved.Jun 30 2017, 12:41 PM

• Jonas moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.

Lucas_Werkmeister_WMDE moved this task from REVIEW to DONE on the Wikibase-Quality board.Jun 30 2017, 12:44 PM

Change 362234 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Include other items in Unique value violation message

https://gerrit.wikimedia.org/r/362234

Lucas_Werkmeister_WMDE merged a task: T169623: Add a list of the entities with the same value in the Unique Constraint Violation message.Jul 4 2017, 12:25 PM

Lucas_Werkmeister_WMDE added a subscriber: Agabi10.

Include other items with the same value in “Unique value” violation messageClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Include other items with the same value in “Unique value” violation message
Closed, ResolvedPublic
Actions