Page MenuHomePhabricator
Create Task
Maniphest T169838

SpamBlacklist blacklist validation is broken
Closed, ResolvedPublic
Actions

Description

BaseBlacklist::getTypeFromTitle() is broken.

> var_dump(BaseBlacklist::getTypeFromTitle(Title::newFromText('MediaWiki:Spam-blacklist')));
bool(false)

Should have returned 'spam'.

The super convoluted code in that function generated a regex of /(spam|email)-(?:Blacklist|Whitelist)/ which has the wrong case to match Spam-blacklist. Adding the i modifier for case insensitivity fixes it.

Details

SubjectRepoBranchLines +/-
Unbreak BaseBlacklist::getTypeFromTitle() and add testsmediawiki/extensions/SpamBlacklistmaster+56 -2
Customize query in gerrit

Event Timeline

Legoktm created this task.Jul 6 2017, 12:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2017, 12:56 AM
gerritbot subscribed.Jul 6 2017, 1:13 AM

Change 363514 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SpamBlacklist@master] Unbreak BaseBlacklist::getTypeFromTitle() and add tests

https://gerrit.wikimedia.org/r/363514

gerritbot added a project: Patch-For-Review.Jul 6 2017, 1:13 AM
Jdforrester-WMF closed this task as Resolved.Jul 7 2017, 11:17 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Jul 8 2017, 1:54 AM

Change 363514 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@master] Unbreak BaseBlacklist::getTypeFromTitle() and add tests

https://gerrit.wikimedia.org/r/363514

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 8 2017, 5:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL