CodeMirror should use only the content language, not the user language
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pastakhov
	Jul 10 2017, 10:34 AM

Description

When the IU language is changed (by uselang param or Language Tool) to a language different than the site language ($wgContLang), CodeMirror gets the wrong list of localized magic words. It should use $wgContLang rather than $context->getLanguage().

Details

	Subject	Repo	Branch	Lines +/-
	Use $wgContLang for retrieving list of Magic Words	mediawiki/extensions/CodeMirror	master	+10 -9

Customize query in gerrit

Related Objects

Mentioned In: T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew

Event Timeline

Pastakhov created this task.Jul 10 2017, 10:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2017, 10:34 AM

Pastakhov mentioned this in T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew.Jul 10 2017, 10:35 AM

Pastakhov updated the task description. (Show Details)Jul 10 2017, 11:01 AM

Change 364187 had a related patch set uploaded (by Pastakhov; owner: Pastakhov):
[mediawiki/extensions/CodeMirror@master] Use $wgLanguageCode for retrieving list of Magic Words

https://gerrit.wikimedia.org/r/364187

gerritbot added a project: Patch-For-Review.Jul 10 2017, 11:12 AM

kaldari updated the task description. (Show Details)Jul 10 2017, 10:02 PM

kaldari renamed this task from CodeMirror should use only language from $wgLanguageCode to CodeMirror should use only the content language, not the user language.Jul 10 2017, 10:50 PM

kaldari updated the task description. (Show Details)

kaldari added a project: Community-Tech-Sprint.Jul 10 2017, 11:09 PM

kaldari moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.

Change 364187 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Use $wgContLang for retrieving list of Magic Words

https://gerrit.wikimedia.org/r/364187

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 11 2017, 1:00 AM

Pastakhov closed this task as Resolved.Jul 11 2017, 8:38 AM

Pastakhov triaged this task as Medium priority.

Pastakhov removed a project: Patch-For-Review.

kaldari moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.Jul 11 2017, 5:01 PM

• DannyH edited projects, added Community-Tech; removed Community-Tech-Sprint.Jul 18 2017, 10:41 PM

• DannyH moved this task from New & TBD Tickets to Archive on the Community-Tech board.Jul 18 2017, 10:44 PM

Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 9 2018, 4:02 PM

CodeMirror should use only the content language, not the user languageClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

CodeMirror should use only the content language, not the user language
Closed, ResolvedPublic
Actions