Page MenuHomePhabricator
Create Task
Maniphest T170170

Possible to select CodeMirror surface under VE NWE using slight gap and end of document
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

There's a few pixels at the end of the document where you can click to put the cursor directly in the CodeMirror surface.

Details

SubjectRepoBranchLines +/-
Ensure CM surface can't be edited in VE modemediawiki/extensions/CodeMirrormaster+2 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 10 2017, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2017, 4:43 PM
gerritbot subscribed.Jul 10 2017, 4:43 PM

Change 364244 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Ensure CM surface can't be edited in VE mode

https://gerrit.wikimedia.org/r/364244

gerritbot added a project: Patch-For-Review.Jul 10 2017, 4:43 PM
gerritbot added a comment.Jul 10 2017, 6:24 PM

Change 364244 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Ensure CM surface can't be edited in VE mode

https://gerrit.wikimedia.org/r/364244

Jdforrester-WMF closed this task as Resolved.Jul 10 2017, 6:27 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 10 2017, 6:27 PM
Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 9 2018, 4:02 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 9 2018, 4:02 PM
• TBolliger moved this task from New & TBD Tickets to Archive on the Community-Tech board.Feb 14 2018, 1:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL