Stop using kludgy workaround for PayPal EC recurring
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When we first implemented EC recurring, the old workflow would pop up for recurring even when we wanted the new one. So instead of setting up a recurring payment immediately, we did a single payment, followed by a recurring payment starting in one month.

https://phabricator.wikimedia.org/T134446#2286371

This is terrible because Donor Services can't find the subscription based on the initial payment, and the PayPal console has no good way to search subscriptions, only payments. [T170470]

Stop doing the workaround, and just set up a recurring payment starting now.

Details

Subject	Repo	Branch	Lines +/-
WIP use INITAMT for first payment	mediawiki/extensions/DonationInterface	master	+4 -1
PayPal EC recurring: initial donation is async	mediawiki/extensions/DonationInterface	master	+11 -50
PayPal EC recurring: initial charge is part of subscription	mediawiki/extensions/DonationInterface	master	+147 -31

Customize query in gerrit

Event Timeline

Ejegg created this task.Jul 12 2017, 8:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2017, 8:59 PM

Change 364903 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] PayPal EC recurring: initial charge is part of subscription

https://gerrit.wikimedia.org/r/364903

gerritbot added a project: Patch-For-Review.Jul 12 2017, 9:48 PM

Ejegg triaged this task as High priority.Jul 12 2017, 9:49 PM

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Murphy's Lawyer board.

Ejegg set the point value for this task to 2.

Updates from a call with PayPal:
The old UI is 98-99% phased out. It's completely gone for the US and a lot of other countries. They will get us a list of the countries where it can still show up. It /does/ show up more often for recurring donors.

• DStrine moved this task from Triage to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Jul 18 2017, 7:14 PM

Change 364903 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] PayPal EC recurring: initial charge is part of subscription

https://gerrit.wikimedia.org/r/364903

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Jul 19 2017, 7:00 PM

• DStrine added a project: Fundraising Sprint Navel Warfare.Jul 19 2017, 8:25 PM

Change 366472 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP use INITAMT for first payment

https://gerrit.wikimedia.org/r/366472

Clarification from PayPal on the phase out of the old UI:

it's still not a 100% ramp, and it'd likely be 6+ months until all use cases and errors no longer have to fallback.
all countries and nearly 96+% of integration use cases are ramped though.

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Navel Warfare board.Jul 21 2017, 4:25 PM

Change 366870 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] PayPal EC recurring: initial donation is async

https://gerrit.wikimedia.org/r/366870

Ejegg moved this task from Doing to Review on the Fundraising Sprint Navel Warfare board.Jul 21 2017, 4:53 PM

Change 366870 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] PayPal EC recurring: initial donation is async

https://gerrit.wikimedia.org/r/366870

Change 366472 abandoned by Ejegg:
WIP use INITAMT for first payment

https://gerrit.wikimedia.org/r/366472

Ejegg moved this task from Review to Done on the Fundraising Sprint Navel Warfare board.Jul 25 2017, 9:18 PM

Ejegg closed this task as Resolved.Aug 2 2017, 7:35 PM