SkinMinerva::insertWatchlistMenuItem should function when SpecialMobileWatchlist doesn't exist
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 20 2017, 10:46 PM

Description

When MobileFrontend is not installed, SpecialMobileWatchlist does not exist.
The logic should not assume it exists.

Fatal error: Class 'SpecialMobileWatchlist' not found in /Users/jrobson/git/core/skins/MinervaNeue/includes/skins/SkinMinerva.php on line 476

Details

	Subject	Repo	Branch	Lines +/-
	Check if SpecialMobileWatchlist exist	mediawiki/skins/MinervaNeue	master	+10 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T171000 [EPIC] Minerva works independently of MobileFrontend
Resolved	Jdlrobson	T171241 SkinMinerva::insertWatchlistMenuItem should function when SpecialMobileWatchlist doesn't exist

Event Timeline

Jdlrobson created this task.Jul 20 2017, 10:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2017, 10:46 PM

Change 372470 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Check if SpecialMobileWatchlist exist

https://gerrit.wikimedia.org/r/372470

gerritbot added a project: Patch-For-Review.Aug 17 2017, 10:17 PM

Change 372470 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Check if SpecialMobileWatchlist exist

https://gerrit.wikimedia.org/r/372470

Jdlrobson closed this task as Resolved.Aug 18 2017, 2:42 AM

Jdlrobson claimed this task.

Jdlrobson added a parent task: T171000: [EPIC] Minerva works independently of MobileFrontend.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 8:01 PM