Page MenuHomePhabricator
Create Task
Maniphest T171335

Add Sniff to forbid PHP 7+ type hints
Closed, ResolvedPublic
Actions

Description

as was removed in https://gerrit.wikimedia.org/r/#/c/366801/

Details

SubjectRepoBranchLines +/-
Add sniff to forbid PHP 7 scalar type hintsmediawiki/tools/codesniffermaster+85 -0
Customize query in gerrit

Event Timeline

Legoktm created this task.Jul 21 2017, 6:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2017, 6:17 PM
Legoktm moved this task from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.Jul 22 2017, 11:47 PM
Ricordisamoa subscribed.Jul 23 2017, 12:50 AM
gerritbot subscribed.Aug 11 2017, 2:02 AM

Change 371219 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/tools/codesniffer@master] Add sniff to forbid PHP 7 scalar type hints

https://gerrit.wikimedia.org/r/371219

gerritbot added a project: Patch-For-Review.Aug 11 2017, 2:02 AM
gerritbot added a comment.Aug 11 2017, 2:14 AM

Change 371219 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Add sniff to forbid PHP 7 scalar type hints

https://gerrit.wikimedia.org/r/371219

Legoktm closed this task as Resolved.Aug 11 2017, 2:18 AM
Legoktm claimed this task.
Ricordisamoa removed a project: Patch-For-Review.Aug 11 2017, 2:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL