[BUG] Weird Settings animation after selecting a new theme from "Manage preferences" in the Theme announcement card
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• NHarateh_WMF
	Jul 27 2017, 4:38 PM

Description

How many times were you able to reproduce it?

Steps to reproduce

Fresh install the app
Tap on "Manage preferences" in the Theme announcement card
Choose a different theme
On nav bar, tap on "< Settings" to return to main Settings

Expected results

Main Settings view remains static

Actual results

Cells in the main Settings view animate in a weird way

Screenshots

gif

Environments observed

App version: 5.6.0 (1184)
OS versions: 10.3.2
Device model: iPhone 6 Plus
Device language: English

Regression?

To me, this happens only the first time I tap on "Manage preferences" and change the theme. When I go back to the feed and tap on "Manage preferences" again (in this build, the card isn't being dismissed after the user taps on "Manage preferences") again, it doesn't happen.
When I go to "Settings" and change the theme, it doesn't happen (even after a fresh install).

Related Objects

Mentioned In: rAPIOSe2aac7a1ab40: Merge pull request #1709 from wikimedia/bug/T171867
rAPIOSbae042f977dc: Merge branch 'bug/T171867' of https://github.com/wikimedia/wikipedia-ios into…
rAPIOS7f059363f6c3: Merge branch 'develop' into bug/T171867
rAPIOSe2b620b7fd40: Merge branch 'develop' into bug/T171867

Event Timeline

• NHarateh_WMF created this task.Jul 27 2017, 4:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2017, 4:38 PM

• NHarateh_WMF renamed this task from [BUG] Weird Settings animation after selecting a new theme to [BUG] Weird Settings animation after selecting a new theme from "Manage preferences" in the Theme announcement card.Jul 27 2017, 4:38 PM

Diffusion mentioned this in rAPIOSe2b620b7fd40: Merge branch 'develop' into bug/T171867.Aug 4 2017, 3:59 AM

• NHarateh_WMF added a project: iOS-app-v5.6.1-Goat-On-A-Plane.Aug 4 2017, 4:00 AM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.6.1-Goat-On-A-Plane board.

• NHarateh_WMF claimed this task.Aug 4 2017, 4:13 AM

Diffusion mentioned this in rAPIOS7f059363f6c3: Merge branch 'develop' into bug/T171867.Aug 4 2017, 1:50 PM

JoeWalsh mentioned this in rAPIOSbae042f977dc: Merge branch 'bug/T171867' of https://github.com/wikimedia/wikipedia-ios into….Aug 4 2017, 2:45 PM

JoeWalsh mentioned this in rAPIOSe2aac7a1ab40: Merge pull request #1709 from wikimedia/bug/T171867.Aug 4 2017, 4:29 PM

• NHarateh_WMF moved this task from Needs Code Review to Needs QA on the iOS-app-v5.6.1-Goat-On-A-Plane board.Aug 4 2017, 5:00 PM

• NHarateh_WMF edited projects, added iOS-app-v5.6.0-Goat-On-A-Train; removed iOS-app-v5.6.1-Goat-On-A-Plane.Aug 4 2017, 5:35 PM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Needs QA on the iOS-app-v5.6.0-Goat-On-A-Train board.

Testing on iPhone 6s (iOS 10.3.3) and Wikipedia app 5.6.0 (1195). This is fixed according to the screencaps below.