Maniphest T172061

passing a category to refreshLinks.php causes a fatal error: Argument 1 passed to RefreshLinks::refreshCategory() must be an instance of Title, string given
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ciencia_Al_Poder
	Jul 30 2017, 1:37 PM

Description

PHP Catchable fatal error: Argument 1 passed to RefreshLinks::refreshCategory() must be an instance of Title, string given, called in /home/jesus/git/mediawiki/core/maintenance/refreshLinks.php on line 75 and defined in /home/jesus/git/mediawiki/core/maintenance/refreshLinks.php on line 433

Looking at the code one can spot an obvious error

Details

	Subject	Repo	Branch	Lines +/-
	refreshLinks.php: Fix fatal when using --category parameter	mediawiki/core	REL1_29	+1 -1
	refreshLinks.php: Fix fatal when using --category parameter	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW13054a4c70c6: refreshLinks.php: allow refreshing by categories, tracking or not

Event Timeline

Ciencia_Al_Poder created this task.Jul 30 2017, 1:37 PM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptJul 30 2017, 1:37 PM

Ciencia_Al_Poder triaged this task as Medium priority.Jul 30 2017, 1:37 PM

Ciencia_Al_Poder moved this task from Backlog to refreshLinks.php on the MediaWiki-Maintenance-system board.

Change 368584 had a related patch set uploaded (by Martineznovo; owner: Martineznovo):
[mediawiki/core@master] refreshLinks.php: Fix fatal when using --category parameter

https://gerrit.wikimedia.org/r/368584

gerritbot added a project: Patch-For-Review.Jul 30 2017, 1:43 PM

Feature broken since its introduction in rMW13054a4c70. gj

Ciencia_Al_Poder added a subscriber: MaxSem.Jul 30 2017, 1:57 PM

Change 368584 merged by jenkins-bot:
[mediawiki/core@master] refreshLinks.php: Fix fatal when using --category parameter

https://gerrit.wikimedia.org/r/368584

MaxSem closed this task as Resolved.Jul 31 2017, 6:46 PM

Change 368835 had a related patch set uploaded (by Martineznovo; owner: Martineznovo):
[mediawiki/core@REL1_29] refreshLinks.php: Fix fatal when using --category parameter

https://gerrit.wikimedia.org/r/368835

Change 368835 merged by jenkins-bot:
[mediawiki/core@REL1_29] refreshLinks.php: Fix fatal when using --category parameter