Inconsistencies around textbox highlighting in link inspector
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

Open VisualEditor on some page.
Highlight some text.
Open link inspector
Now switch from "Search Pages" to "External link" tab, observe that the highlight around text box is red
Now switch back to "Search Pages"
Switch back to "External link", this time the highlight around the text box is blue.

Details

	Subject	Repo	Branch	Lines +/-
	MWLinkAnnotationInspector: check input validity when switching modes	mediawiki/extensions/VisualEditor	master	+4 -0

Customize query in gerrit

Event Timeline

Ryasmeen created this task.Jul 31 2017, 11:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2017, 11:21 PM

• Deskana triaged this task as Medium priority.Aug 1 2017, 7:07 PM

• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.

• Deskana set the point value for this task to 1.

• Deskana added a project: VisualEditor-MediaWiki-Links.

It seems to always be blue for me. Are you still seeing this, or...?

I can't get this to work with these exact reproduction steps, but if you change step 1 to "Highlight some text and open link inspector" then this can be reproduced. I'll change the description.

• Deskana updated the task description. (Show Details)Aug 29 2017, 3:50 PM

Ah, I think my own "try selecting something" phase accidentally hit some text which was a valid URL, explaining my problems.

Change 374563 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWLinkAnnotationInspector: check input validity when switching modes

https://gerrit.wikimedia.org/r/374563

gerritbot added a project: Patch-For-Review.Aug 29 2017, 4:29 PM

Change 374563 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWLinkAnnotationInspector: check input validity when switching modes

https://gerrit.wikimedia.org/r/374563

• Deskana closed this task as Resolved.Aug 29 2017, 5:57 PM

• Deskana assigned this task to DLynch.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 29 2017, 5:57 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Aug 29 2017, 6:01 PM

Ryasmeen edited projects, added Verified-in-Phase0; removed Patch-For-Review.Aug 30 2017, 4:35 PM

Ryasmeen added a project: Verified.Sep 6 2017, 10:12 PM

Inconsistencies around textbox highlighting in link inspector Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Inconsistencies around textbox highlighting in link inspector
Closed, ResolvedPublic1 Estimated Story Points
Actions