Page MenuHomePhabricator
Create Task
Maniphest T172659

Tool "locator" loads Google Maps
Closed, ResolvedPublic
Actions

Description

http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps?file=api&v=2&key=ABQIAAAATOABawFK4d0GxFH60StEBxQFKH2rfuS4XzLqOCK0qFXohIQoExTWSfb1fhWJvgcdhwwJHk_LQI7BVg
http://tools.wmflabs.org/locator/coordinates.php: http://www.google.com/uds/api?file=uds.js&v=1.0
http://tools.wmflabs.org/locator/coordinates.php: http://www.google.com/uds/solutions/localsearch/gmlocalsearch.js
http://tools.wmflabs.org/locator/coordinates.php: http://www.google.com/uds/css/gsearch.css
http://tools.wmflabs.org/locator/coordinates.php: http://www.google.com/uds/solutions/localsearch/gmlocalsearch.css
http://tools.wmflabs.org/locator/coordinates.php: http://uds.googleusercontent.com/uds/solutions/localsearch/gmlocalsearch.css
http://tools.wmflabs.org/locator/coordinates.php: http://uds.googleusercontent.com/uds/solutions/localsearch/gmlocalsearch.js
http://tools.wmflabs.org/locator/coordinates.php: http://csi.gstatic.com/csi?v=2&s=mapsapi3&v3v=29.13&action=apiboot2&libraries=adsense%2Cgeometry%2Czombie&e=10_1_0,10_2_0&rt=main.25
http://tools.wmflabs.org/locator/coordinates.php: http://www.google.com/uds/api/search/1.0/01d3e4019d02927b30f1da06094837dc/default+en.I.js
http://tools.wmflabs.org/locator/coordinates.php: http://csi.gstatic.com/csi?v=2&s=mapsapi3&v3v=29.13&action=apiboot2&libraries=adsense%2Cgeometry%2Czombie&e=10_1_0,10_2_0&rt=firstmap.1779
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/common.js
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/map.js
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/overlay.js
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/util.js
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/infowindow.js
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/onion.js
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/openhand_8_8.cur
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/controls.js
http://tools.wmflabs.org/locator/coordinates.php: http://csi.gstatic.com/csi?v=2&s=mapsapi3&v3v=29.13&action=map2&firstmap=false&hdpi=false&mob=false&staticmap=false&size=800x600&hadviewport=true&libraries=adsense%2Cgeometry%2Czombie&e=10_1_0,10_2_0&rt=visreq.322
http://tools.wmflabs.org/locator/coordinates.php: http://maps.googleapis.com/maps/api/js/ViewportInfoService.GetViewportInfo?1m6&1m2&1d45.865069371102734&2d-8.523596962771308&2m2&1d58.4475220304318&2d18.264850634509912&2u7&4sen-US&5e0&6sm%40386000000&7b0&8e0&callback=_xdc_._cxfo56&token=12643
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/transparent.png
http://tools.wmflabs.org/locator/coordinates.php: http://fonts.googleapis.com/css?family=Roboto:300,400,500,700
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/api-3/images/google4.png
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/api-3/images/mapcnt6.png
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps-api-v3/api/js/29/13/marker.js
http://tools.wmflabs.org/locator/coordinates.php: http://csi.gstatic.com/csi?v=2&s=mapsapi3&v3v=29.13&action=map2&firstmap=false&hdpi=false&mob=false&staticmap=false&size=800x600&hadviewport=true&libraries=adsense%2Cgeometry%2Czombie&e=10_1_0,10_2_0&rt=visres.655
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i65!3i42!4i256!2m3!1e0!2sm!3i386080964!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=96049
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i66!3i42!4i256!2m3!1e0!2sm!3i386080964!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=22165
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i65!3i41!4i256!2m3!1e0!2sm!3i386080820!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=2234
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i65!3i43!4i256!2m3!1e0!2sm!3i386080964!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=999
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i66!3i41!4i256!2m3!1e0!2sm!3i386080820!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=59421
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i66!3i43!4i256!2m3!1e0!2sm!3i386080964!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=58186
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i64!3i42!4i256!2m3!1e0!2sm!3i386081012!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=70447
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i67!3i42!4i256!2m3!1e0!2sm!3i386080964!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=79352
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i64!3i41!4i256!2m3!1e0!2sm!3i386081012!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=34426
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i64!3i43!4i256!2m3!1e0!2sm!3i386081012!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=106468
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i67!3i41!4i256!2m3!1e0!2sm!3i386080820!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=116608
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m5!1m4!1i7!2i67!3i43!4i256!2m3!1e0!2sm!3i386080964!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e0&token=115373
http://tools.wmflabs.org/locator/coordinates.php: http://fonts.gstatic.com/s/roboto/v16/zN7GBFwfMP4uA6AR0HCoLQ.ttf
http://tools.wmflabs.org/locator/coordinates.php: http://fonts.gstatic.com/s/roboto/v16/RxZJdnzeo3R5zSexge8UUaCWcynf_cDxXwCLxiixG1c.ttf
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/api-3/images/tmapctrl.png
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/api-3/images/cb_scout5.png
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/api-3/images/tmapctrl4.png
http://tools.wmflabs.org/locator/coordinates.php: http://maps.gstatic.com/mapfiles/mv/imgs8.png
http://tools.wmflabs.org/locator/coordinates.php: http://maps.google.com/maps/vt?pb=!1m4!1m3!1i7!2i64!3i41!1m4!1m3!1i7!2i65!3i41!1m4!1m3!1i7!2i64!3i42!1m4!1m3!1i7!2i64!3i43!1m4!1m3!1i7!2i65!3i42!1m4!1m3!1i7!2i65!3i43!1m4!1m3!1i7!2i66!3i41!1m4!1m3!1i7!2i67!3i41!1m4!1m3!1i7!2i66!3i42!1m4!1m3!1i7!2i66!3i43!1m4!1m3!1i7!2i67!3i42!1m4!1m3!1i7!2i67!3i43!2m3!1e0!2sm!3i386081012!3m9!2sen-US!3sUS!5e18!12m1!1e68!12m3!1e37!2m1!1ssmartmaps!4e3!12m1!5b1&callback=_xdc_._z2nf2e&token=117113
http://tools.wmflabs.org/locator/coordinates.php: http://csi.gstatic.com/csi?v=2&s=mapsapi3&v3v=29.13&action=map2&firstmap=false&hdpi=false&mob=false&staticmap=false&size=800x600&hadviewport=true&libraries=adsense%2Cgeometry%2Czombie&e=10_1_0,10_2_0&rt=firsttile.883,firstpixel.883

Loading from external providers are discouraged. Please see parent tasks and J65.

You may want to refer to https://www.mediawiki.org/wiki/Maps for how to migrate to Wikimedia Maps service.

Related Objects
Search...

Event Timeline

zhuyifei1999 created this task.Aug 6 2017, 10:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2017, 10:58 PM
zhuyifei1999 added a comment.Aug 6 2017, 10:58 PM

The other maintainer is Silver_Spoon. I cannot find their Phabricator username.

TheDJ added a comment.Aug 21 2017, 11:45 AM

This would require a bit of a rewrite to provide the same functionality using Leaflet.js

I do note, that this page has a considerable warning on the page regarding privacy expectations when using 3rd party services.

TheDJ closed this task as Resolved.Mar 15 2018, 11:35 AM
TheDJ claimed this task.

So I did write an alternative to this at some point. I was trying to preserve the Google fallbacks (as they seem popular with the community), by giving explicit consent options etc, but I have way too little time to do that correctly.

As it's now 9 months on, i've decided to just put that newer version live, without google options. If anyone actually TRULY cares then he is free and encouraged to invest their own time to enable non-free sources with explicit user consent...

Akoopal added a comment.Mar 15 2018, 12:27 PM

What I am missing at the moment is a search-box to quickly jump to a
location.

But thanks for picking this up.

Regards,

André

TheDJ added a comment.Mar 15 2018, 4:53 PM
In T172659#4052902, @Akoopal wrote:

What I am missing at the moment is a search-box to quickly jump to a
location.

The old one didn't have that either did it ? There's several more tools on tools labs that deal with geocoding and bidirectional lookups. it would help if we could bring some of that stuff together, as maintaining all these different half abandoned projects is just a pain....

Akoopal added a comment.Mar 15 2018, 5:06 PM

It had. The default google api included a search box with the map widget.
This is jsut about typing in for example 'Amsterdam' and from there zoom in
to the appropriate location. Not sure if this API supports it as well?

I don't mind moving the tool to a general project, and I am sure Maarten
doesn't either, but you need the old url working.

Regards,

André

TheDJ added a comment.Mar 15 2018, 6:44 PM
In T172659#4053782, @Akoopal wrote:

It had. The default google api included a search box with the map widget.

I just checked the old code to make sure, It positively didn't. I think you are confused with https://tools.wmflabs.org/coord/

Multichill added a comment.Mar 15 2018, 6:47 PM
In T172659#4054233, @TheDJ wrote:
In T172659#4053782, @Akoopal wrote:

It had. The default google api included a search box with the map widget.

I just checked the old code to make sure, It positively didn't. I think you are confused with https://tools.wmflabs.org/coord/

Could have been the ancient Toolserver version

Akoopal added a comment.Mar 15 2018, 6:56 PM

Checked myself now, you are definitely right for the last running version. Maybe that changed indeed over time.I have used this one a lot a couple of years ago, and much less in the last years.

Still I think it will be a nice feature, when I have time (ahem) I might investigate myself.

To be clear, I do think this version is good and very workable.

TheDJ added a comment.Mar 16 2018, 12:46 PM

Google has productised the geocode lookup (aka, many requests now cost money) in 2011, it might be that whatever the implementation was, broke back then and it was removed instead of fixed. Seems like a very likely scenario.

TheDJ added a comment.Mar 16 2018, 3:05 PM

Played a bit with leaflet-geosearch and Nominatim from OSM.
Opened T189879: Set up a Nominatim instance to avoid geocode lookups with Google and/or OSM from tools

TheDJ added a comment.EditedMar 23 2018, 1:34 PM

I'm just gonna mention some related sibling tickets, so that people/tools with similar problems can easily find eachother.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits