Page MenuHomePhabricator
Create Task
Maniphest T173016

Editing widget for <pages> and <pagequality> tag are broken
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The editing widgets for <pages> and <pagequality> tags are currently badly displayed and, so, unusable because of a JS error.

To reproduce for the <pagequality> tag go to https://en.wikisource.org/wiki/Page:Scientific_American_-_Series_1_-_Volume_001_-_Issue_01.pdf/3 click "edit" and then try to edit the <pagequality> tag (the one in green saying "This page has been validated.".

For the <pages> tag go to https://en.wikisource.org/wiki/Scientific_American/Series_1/Volume_1/Issue_1/New_Article_of_Export?veaction=edit and try to edit the text (starting with "New article for export").

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+5 -3Allow for mw.body being null in <selfclosing/> extensions
Customize query in gerrit

Event Timeline

Tpt created this task.Aug 10 2017, 4:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2017, 4:10 PM
Tpt moved this task from Backlog to Top priority on the ProofreadPage board.Aug 10 2017, 4:10 PM
jayantanth added a subscriber: jayantanth.Aug 10 2017, 4:11 PM
gerritbot added a subscriber: gerritbot.Aug 23 2017, 2:06 PM

Change 373293 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Allow for mw.body being null in <selfclosing/> extensions

https://gerrit.wikimedia.org/r/373293

gerritbot added a project: Patch-For-Review.Aug 23 2017, 2:06 PM
gerritbot added a comment.Aug 23 2017, 4:40 PM

Change 373293 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Allow for mw.body being null in <selfclosing/> extensions

https://gerrit.wikimedia.org/r/373293

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Aug 23 2017, 5:00 PM
Deskana closed this task as Resolved.Aug 28 2017, 7:09 PM
Deskana assigned this task to Esanders.
Deskana triaged this task as Medium priority.
Deskana set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 28 2017, 7:09 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL