securepoll should use MWCryptRand not mt_rand() when creating a random temp directory
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bawolff
	Aug 15 2017, 10:16 PM

Description

in line 195 of includes/crypt/Crypt.php:

$this->homeDir = $wgSecurePollTempDir . '/securepoll-' . sha1( mt_rand() . mt_rand() );

This should use MWCryptRand instead.

Details

	Subject	Repo	Branch	Lines +/-
	Replaced mt_rand() with MWCryptRand	mediawiki/extensions/SecurePoll	master	+1 -1

Customize query in gerrit

Event Timeline

Bawolff created this task.Aug 15 2017, 10:16 PM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptAug 15 2017, 10:16 PM

wassan.anmol117 subscribed.Aug 17 2017, 10:24 AM

wassan.anmol117 claimed this task.Aug 17 2017, 10:33 AM

Change 372364 had a related patch set uploaded (by Wassan.anmol; owner: Anmol):
[mediawiki/extensions/SecurePoll@master] Replaced mt_rand() with MWCryptRand

https://gerrit.wikimedia.org/r/372364

gerritbot added a project: Patch-For-Review.Aug 17 2017, 11:52 AM

Bawolff closed this task as Resolved.Aug 17 2017, 8:48 PM

Change 372364 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Replaced mt_rand() with MWCryptRand

https://gerrit.wikimedia.org/r/372364

Huji removed a project: Patch-For-Review.Aug 18 2017, 7:23 AM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 7:01 PM

securepoll should use MWCryptRand not mt_rand() when creating a random temp directoryClosed, ResolvedPublicActions

Description

Details

Event Timeline

securepoll should use MWCryptRand not mt_rand() when creating a random temp directory
Closed, ResolvedPublic
Actions