Page MenuHomePhabricator

Autoload maintenance classes in Flow for addPostDatabaseUpdateMaintenance
Open, Needs TriagePublic

Description

Why are we require_once'ing maintenance scripts?

These classes should be added to the autoloader, and then the require_once calls wouldn't be needed

		require_once __DIR__.'/maintenance/FlowUpdateRecentChanges.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowUpdateRecentChanges' );
		require_once __DIR__.'/maintenance/FlowSetUserIp.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowSetUserIp' );
		require_once __DIR__.'/maintenance/FlowUpdateUserWiki.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowUpdateUserWiki' );
		require_once __DIR__.'/maintenance/FlowUpdateRevisionTypeId.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowUpdateRevisionTypeId' );
		require_once __DIR__.'/maintenance/FlowPopulateLinksTables.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowPopulateLinksTables' );
		require_once __DIR__.'/maintenance/FlowFixLog.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowFixLog' );
		require_once __DIR__.'/maintenance/FlowUpdateWorkflowPageId.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowUpdateWorkflowPageId' );
		require_once __DIR__.'/maintenance/FlowCreateTemplates.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowCreateTemplates' );
		require_once __DIR__.'/maintenance/FlowFixLinks.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowFixLinks' );
		require_once __DIR__.'/maintenance/FlowUpdateBetaFeaturePreference.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowUpdateBetaFeaturePreference' );
		require_once __DIR__.'/maintenance/FlowPopulateRefId.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowPopulateRefId' );
		require_once __DIR__.'/maintenance/FlowFixInconsistentBoards.php';
		$updater->addPostDatabaseUpdateMaintenance( 'FlowFixInconsistentBoards' );

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 373613 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Flow@master] Hooks::getSchemaUpdates: Don't require_once maintainance scripts, add to autoloader

https://gerrit.wikimedia.org/r/373613

Change 373613 abandoned by Reedy:
Hooks::getSchemaUpdates: Don't require_once maintainance scripts, add to autoloader

Reason:
Done in newer commit

https://gerrit.wikimedia.org/r/373613