Page MenuHomePhabricator

Article name shouldn't be highlighted in the content on the irc feed
Closed, ResolvedPublic

Description

<rc> \x0314[[\x0307Especial:Log/delete\x0314]]\x034 delete\x0310 \x0302\x03 \x035*\x03 \x0303Antur\x03 \x035*\x03 \x0310«[[\x0302FIFA\x0310]]» borrado: Sin contenido académico: El contenido era: '[[Imagen:\x0302FIFA\x0310_Kontinentalverbaende.png|thumb|250px|La \x0302FIFA\x0310 tiene seis confederaciones continentales afiliadas.]] La '''Fédération internationale de...' (y el único autor fue '[[Special:Contributions/190.30.129.186|190.30.129.186]]')


Version: 1.14.x
Severity: enhancement

Details

Reference
bz15428

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:16 PM
bzimport set Reference to bz15428.

The above message was produced in the irc feeds. As you can see (or could if it was presented better), the word FIFA (the article name) is highlighted in the summary which comes from the content. Even though it's not related. It should only be highlighted the first time.
The way to fix it I see is by substituting the str_replace on RecentChange.php:605 with a regex stoppping at the first colon, but perhaps someone has a better alternative?

Maybe some look-aheads are in order. [[x]] links should still be colored (for consistency).

(In reply to comment #2)

Maybe some look-aheads are in order. [[x]] links should still be colored (for
consistency).

Actually, that could use str_replace

Fixed in r41980, it highlights [[x]] links now, rather than anything x.