Page MenuHomePhabricator
Create Task
Maniphest T175285

Quarry XLSX cells for long urls are wrongly empty
Closed, ResolvedPublic
Actions

Description

Eg. https://quarry.wmflabs.org/query/21263:

Firefox_Screenshot_2017-09-07T16-06-45.212Z.png (3×1 px, 400 KB)

Download: https://quarry.wmflabs.org/run/202171/output/0/xlsx?download=true
quarry-21263-hewiki-google-links-run202171.xlsx10 KBDownload

LibreOffice Calc, Version 5.1.6.2 shows:
Screenshot from 2017-09-07 11-07-58.png (744×1 px, 194 KB)

Many cells are wrongly empty.

Details

SubjectRepoBranchLines +/-
output: Fallback to write_string when some error occur in write for xlsxanalytics/quarry/webmaster+10 -2
Customize query in gerrit

Related Objects

Event Timeline

zhuyifei1999 created this task.Sep 7 2017, 4:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2017, 4:09 PM
zhuyifei1999 added a comment.Sep 7 2017, 4:16 PM

(Originally reported by @IKhitron on https://www.mediawiki.org/wiki/Topic:Txnc2f9ndpwke6w4)

zhuyifei1999 added a comment.Sep 7 2017, 4:24 PM

https://quarry.wmflabs.org/query/21425, 2048 characters plain text can be downloaded.

zhuyifei1999 added a comment.Sep 7 2017, 4:29 PM

https://quarry.wmflabs.org/query/21426, 151 characters url can be but 279 cannot.

zhuyifei1999 added a comment.Sep 7 2017, 4:43 PM

The same happens with xlsxwriter 0.9.9 instead of 0.5.2.

zhuyifei1999 added a comment.Sep 7 2017, 4:44 PM
Sep  7 16:42:41 jessie python[26945]: /srv/venv/local/lib/python2.7/site-packages/xlsxwriter/worksheet.py:831: UserWarning: Ignoring URL 'http://www.example.com/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' with link or location/anchor > 255 characters since it exceeds Excel's limit for URLS
IKhitron added a comment.Sep 7 2017, 4:45 PM

Wait a moment, it's excel's bug???

zhuyifei1999 added a comment.Sep 7 2017, 4:51 PM

This is raised in https://github.com/jmcnamara/XlsxWriter/blob/b4c4b499ffb3db8e0fa1b306880bcbcb3675fd4d/xlsxwriter/worksheet.py#L828

What do you think of forcing string instead of url when it is longer then 255 chars? This will affect formulas as well.

zhuyifei1999 added a comment.EditedSep 7 2017, 4:52 PM
In T175285#3588924, @IKhitron wrote:

Wait a moment, it's excel's bug???

Yes, you can't possibly add urls longer than 255 chars apparently.

IKhitron added a comment.Sep 7 2017, 4:52 PM

Excellent for me.

gerritbot subscribed.Sep 7 2017, 6:00 PM

Change 376561 had a related patch set uploaded (by Zhuyifei1999; owner: Zhuyifei1999):
[analytics/quarry/web@master] output: Fallback to write_string when some error occur in write for xlsx

https://gerrit.wikimedia.org/r/376561

gerritbot added a project: Patch-For-Review.Sep 7 2017, 6:00 PM
gerritbot added a comment.Sep 8 2017, 6:03 PM

Change 376561 merged by jenkins-bot:
[analytics/quarry/web@master] output: Fallback to write_string when some error occur in write for xlsx

https://gerrit.wikimedia.org/r/376561

Stashbot subscribed.Sep 8 2017, 6:06 PM

Mentioned in SAL (#wikimedia-cloud) [2017-09-08T18:06:42Z] <zhuyifei1999_> Deployed d9e8a4a to quarry-main-01 T175285

zhuyifei1999 closed this task as Resolved.Sep 8 2017, 6:09 PM

Should be resolved. Such text are no longer written as a link but as basic string. Please reopen if there are issues.

IKhitron added a comment.Sep 8 2017, 6:12 PM

Checked. Works great. Thank you, @zhuyifei1999.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits