Page MenuHomePhabricator
Create Task
Maniphest T175596

WikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete hook
Closed, ResolvedPublic
Actions

Description

Since I50dcb841cd0616acc2d69c3a685ba3cb339986c3 the hook takes a 12th parameter. WikiPage::doCreate should provide the default (0) for this parameter since it isn't undoing a revision.

Details

SubjectRepoBranchLines +/-
WikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete hookmediawiki/coremaster+2 -2
Customize query in gerrit

Event Timeline

MarkAHershberger created this task.Sep 11 2017, 4:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2017, 4:14 PM
gerritbot subscribed.Sep 11 2017, 4:24 PM

Change 377299 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@master] WikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete hook

https://gerrit.wikimedia.org/r/377299

gerritbot added a project: Patch-For-Review.Sep 11 2017, 4:24 PM
matmarex subscribed.Sep 12 2017, 2:19 PM

In fact, the 10th and 11th parameters are also missing from this call.

matmarex added a comment.Sep 13 2017, 4:35 PM

In fact, they are not, I misread. Ignore me.

gerritbot added a comment.Sep 13 2017, 4:41 PM

Change 377299 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::doCreate() should provide 12th parameter to PageContentSaveComplete hook

https://gerrit.wikimedia.org/r/377299

matmarex closed this task as Resolved.Sep 13 2017, 4:48 PM
matmarex removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL