Page MenuHomePhabricator

Extension:NewUserMessage should not use bogus CheckUser data
Closed, ResolvedPublic

Description

Author: mike.lifeguard+bugs

Description:
Currently the edits made by the extension are attributed to the pseudo-bot account, but the underlying CheckUser data seems to be appropriated from the user who is being welcomed, which pollutes the CU data, and is generally a bit confusing. Two solutions are possible, I think

  1. The edits are not logged in the CheckUser table. Since the edits are made by a system process, we don't care what the CU data is at all (though that will be confusing for anyone who doesn't know it is not a "real" user)
  2. Alternatively, the CU data can be forced to IP=127.0.0.1 and a user agent like "System process for [[mw:Extension:NewUser:Message]]"

CCing Siebrand, since he last worked on the extension.


Version: unspecified
Severity: normal

Details

Reference
bz15592

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:20 PM
bzimport set Reference to bz15592.
bzimport added a subscriber: Unknown Object (MLST).

fran wrote:

Fixed in r40806 by forcing EDIT_SUPPRESS_RC on all edits made by NewUserMessage.